[6.x] Modals should use the same portal as stacks #13202
Merged
+110
−88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # resources/js/api.js # resources/js/components/portals/PortalTargets.vue
… just remove it completely ... if you had a stack open, it would be locked. then if you open a modal, it would still be locked (or get re-locked?) then when you close the modal, it would get unlocked which was incorrect since the stack is still open.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors how modals work under the hood, so they use the same portal as stacks, avoiding all sorts of layering issues (eg. stacks under modals).
Fixes #12555
Related: #12490