Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2892 Allow user-defined DoF kernels to act on field vectors #2897

Merged
merged 15 commits into from
Feb 21, 2025

Conversation

mo-alistairp
Copy link
Collaborator

No description provided.

@mo-alistairp mo-alistairp added bug enhancement LFRic Issue relates to the LFRic domain labels Feb 13, 2025
@mo-alistairp mo-alistairp self-assigned this Feb 13, 2025
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.89%. Comparing base (7445d7e) to head (6773520).
Report is 16 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2897   +/-   ##
=======================================
  Coverage   99.89%   99.89%           
=======================================
  Files         359      359           
  Lines       51083    51084    +1     
=======================================
+ Hits        51031    51032    +1     
  Misses         52       52           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TeranIvy TeranIvy self-requested a review February 14, 2025 08:54
@TeranIvy TeranIvy added under review Release Planning and creating PSyclone releases ready for review and removed under review labels Feb 14, 2025
@TeranIvy TeranIvy requested a review from arporter February 14, 2025 16:51
@TeranIvy TeranIvy marked this pull request as ready for review February 14, 2025 16:51
@TeranIvy
Copy link
Collaborator

TeranIvy commented Feb 14, 2025

Changing the label as there is another PR for the release and Andy may agree to do this one.

P.S. @mo-alistairp, does the developer or user guide need to be updated as well if the limitation is mentioned there, too?

Copy link
Member

@arporter arporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this Alistair. I'm afraid it needs some more work as the code being generated is not correct currently - please see inline.

@mo-alistairp
Copy link
Collaborator Author

Thanks for reviewing that so quickly, I'll look at addressing the points now!

@mo-alistairp
Copy link
Collaborator Author

Addressed all comments and added both the code generation and documentation.

Copy link
Member

@arporter arporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mo-alistairp, looking good now. There's just a couple of TODO's required to flag that there's an issue that @sergisiso will fix in his PR for #1010. I've fired off the integration tests.
Have you tried this in anger in a version of LFRic modified to make use of this new functionality?

Copy link
Member

@arporter arporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now, thanks.
Integration tests were all green.
I'll proceed to merge but note that this will need testing against a suitably modified LFRic prior to us making a release.

@arporter arporter merged commit f7bce31 into master Feb 21, 2025
13 checks passed
@arporter arporter deleted the 2892_support_user_defined_dof_kernels_field_vector branch February 21, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug enhancement LFRic Issue relates to the LFRic domain ready to be merged Release Planning and creating PSyclone releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants