This repository has been archived by the owner on Jul 1, 2024. It is now read-only.
Vault #30
Merged
Vault #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Giblin <[email protected]>
Signed-off-by: Chris Giblin <[email protected]>
Signed-off-by: Chris Giblin <[email protected]>
Signed-off-by: Chris Giblin <[email protected]>
Signed-off-by: Chris Giblin <[email protected]>
Signed-off-by: Chris Giblin <[email protected]>
Signed-off-by: Chris Giblin <[email protected]>
Signed-off-by: Chris Giblin <[email protected]>
Signed-off-by: Chris Giblin <[email protected]>
…licy from JSON Signed-off-by: Chris Giblin <[email protected]>
…d validate method. Formatting Signed-off-by: Chris Giblin <[email protected]>
Signed-off-by: Chris Giblin <[email protected]>
…onfig info Signed-off-by: Chris Giblin <[email protected]>
Signed-off-by: Chris Giblin <[email protected]>
Signed-off-by: Chris Giblin <[email protected]>
Signed-off-by: Chris Giblin <[email protected]>
Signed-off-by: Chris Giblin <[email protected]>
Signed-off-by: Chris Giblin <[email protected]>
Signed-off-by: Chris Giblin <[email protected]>
Merged
tombentley
reviewed
Jul 7, 2022
There was a problem hiding this comment.
Thanks @chris-giblin! I left a few comments, mostly minor suggestions, but a few more meaningful questions.
encmod/src/main/java/io/strimzi/kafka/topicenc/kms/KeyMgtSystem.java
Outdated
Show resolved
Hide resolved
encmod/src/main/java/io/strimzi/kafka/topicenc/kms/VaultKms.java
Outdated
Show resolved
Hide resolved
encmod/src/main/java/io/strimzi/kafka/topicenc/policy/BasicPolicyRepo.java
Outdated
Show resolved
Hide resolved
encmod/src/main/java/io/strimzi/kafka/topicenc/policy/JsonPolicyLoader.java
Outdated
Show resolved
Hide resolved
encmod/src/main/java/io/strimzi/kafka/topicenc/policy/JsonPolicyLoader.java
Outdated
Show resolved
Hide resolved
encmod/src/main/java/io/strimzi/kafka/topicenc/policy/JsonPolicyLoader.java
Outdated
Show resolved
Hide resolved
encmod/src/test/java/io/strimzi/kafka/topicenc/kms/vault/VaultKmsTests.java
Outdated
Show resolved
Hide resolved
…n.java Co-authored-by: Tom Bentley <[email protected]> Signed-off-by: Chris Giblin <[email protected]>
Signed-off-by: Chris Giblin <[email protected]>
Signed-off-by: Chris Giblin <[email protected]>
Signed-off-by: Chris Giblin <[email protected]>
Signed-off-by: Chris Giblin <[email protected]>
Signed-off-by: Chris Giblin <[email protected]>
Signed-off-by: Chris Giblin <[email protected]>
Signed-off-by: Chris Giblin <[email protected]>
Signed-off-by: Chris Giblin <[email protected]>
Signed-off-by: Chris Giblin <[email protected]>
Signed-off-by: Chris Giblin <[email protected]>
Signed-off-by: Chris Giblin <[email protected]>
|
@tombentley I believe all suggestions have been addressed. |
Closed
tombentley
approved these changes
Jul 21, 2022
There was a problem hiding this comment.
Thanks @chris-giblin, a few more nits, but assuming you're happy to fix them this LGTM.
Comment on lines
-2
to
+3
| * Copyright Strimzi authors. | ||
| * License: Apache License 2.0 (see the file LICENSE or http://apache.org/licenses/LICENSE-2.0.html). | ||
| * Copyright Strimzi authors. License: Apache License 2.0 (see the file LICENSE or | ||
| * http://apache.org/licenses/LICENSE-2.0.html). |
encmod/src/main/java/io/strimzi/kafka/topicenc/kms/KmsException.java
Outdated
Show resolved
Hide resolved
encmod/src/main/java/io/strimzi/kafka/topicenc/kms/TestKms.java
Outdated
Show resolved
Hide resolved
encmod/src/main/java/io/strimzi/kafka/topicenc/kms/VaultKms.java
Outdated
Show resolved
Hide resolved
…n.java Co-authored-by: Tom Bentley <[email protected]> Signed-off-by: Chris Giblin <[email protected]>
Signed-off-by: Chris Giblin <[email protected]>
Signed-off-by: Chris Giblin <[email protected]>
Signed-off-by: Chris Giblin <[email protected]>
Signed-off-by: Chris Giblin <[email protected]>
Signed-off-by: Chris Giblin <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First impl of vault KMS. Added config infrastructure and performed some refactoring.
The ensuing changes to the proxy will be in he next PR.