Replace sugar3 references with sugar4

[chimosky]

I've also removed the redefinitions of *ICON_SIZE in sugar4.graphics.icon, we had all that defined in style so duplicating wasn't necessary.

I moved Icon from a Gtk.Widget back to a Gtk.Image, I don't see why it was changed before as Gtk.Image still exists and is expected to be the same. There was no need for a Icon.get_gtk_image seeing as I moved back to Gtk.Image.

MenuItem has been moved to a Gio.MenuItem, with a Gtk.Box, css styling was applied directly and I think that's not needed as we have a menuitem styling in sugar-artwork.

@MostlyKIGuess kindly review.

[MostlyKIGuess]

MenuItem

The MenuItem class was changed from Gtk.Button to Gio.MenuItem, but as Gio.MenuItem is not a widget, it's a data model class. Henceforth we won't be able to call widget methods.
The following won't work:

-  self.add_css_class("menuitem")` 
- `self.connect("map", ...)` 
- `self.get_sensitive()`   
- `self.emit("clicked")` 

Ref: https://docs.gtk.org/gtk4/migrating-3to4.html#gtkmenu-gtkmenubar-and-gtkmenuitem-are-gone

We can keep them as Button with our CSS and that should handle the porting, I am not sure if this is even architecturally correct.

Some other nits on menuitem.py:
L:72 self.set_icon(icon.get_gicon())
We don't have get_icon()..

L:87 self._label = Gtk.Label(label=text_label) self.set_label(self._label) # set_label() expects STRING, not widget

Icons

Also all the icon tests were failing and there are mentions of sugar3 in the docstrings.
Does this actually work? Can you override do_snapshot() on Gtk.Image?

I am not able to run any examples/tests for now. But from what I understand:

• Icon has extensive custom rendering logic (SVG loading, color customization, badge rendering)
• It overrides do_snapshot() and do_measure() for custom drawing
• Gtk.Image was designed to display pre-rendered content (pixbufs, textures, icon names)
• Using Gtk.Image as a base but overriding its rendering defeats the purpose defeats our purpose.

We can either keep Widget with custom rendering, original implementation or run the examples/test with Image and see if anything breaks..

• Thank you for removing duplicate Icon Size Constants

Po files

• Thank you for these paths and sugar4 references.

[MostlyKIGuess]

Could you explain this? We would prefer development mode for testing right?

[chimosky]

I'm running this in the live build, and I needed that.

Anyone running in the live build would too.

I haven't tested most of my changes because there's still much that needs to be done to get it to the point where you can see your changes, I've been moving forward by fixing build errors.

[MostlyKIGuess]

We can perhaps have make install-live-build?

[chimosky]

That can work.

[chimosky]

We can keep them as Button with our CSS and that should handle the porting, I am not sure if this is even architecturally correct.

I do think that the css needs to go, that's why sugar-artwork exists, keeping it is just duplicating what already exists.
I'll drop the change on menuitem, it's on me for not testing extensively.

We don't have get_icon()..

Gtk.Image does, which is what Icon inherited from.

Also all the icon tests were failing and there are mentions of sugar3 in the docstrings.

I forgot to change those.

Does this actually work? Can you override do_snapshot() on Gtk.Image?

I didn't test this like you did, like I said I was going off build errors, I'll test it like you do.

You can override do_snapshot it's a virtual method.

Using Gtk.Image as a base but overriding its rendering defeats the purpose defeats our purpose.

How does this defeat our purpose? Most of the icons in Sugar are installed using sugar-artwork and can be referenced with their icon name when using them, that's exactly why Gtk.Image makes sense.

We can either keep Widget with custom rendering, original implementation or run the examples/test with Image and see if anything breaks..

I'm glad with running the example test with Image, as that'll reduce the complexity of having custom rendering.