-
Notifications
You must be signed in to change notification settings - Fork 12
Replace sugar3 references with sugar4 #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
chimosky
wants to merge
3
commits into
main
Choose a base branch
from
fixes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| dist_bin_SCRIPTS = sugar-activity sugar-activity-web sugar-activity3 | ||
| dist_bin_SCRIPTS = sugar-activity sugar-activity-web sugar-activity4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| #!/usr/bin/env python2 | ||
|
|
||
| from sugar3.activity import activityinstance | ||
| from sugar4.activity import activityinstance | ||
|
|
||
| activityinstance.main() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| #!/usr/bin/env python3 | ||
|
|
||
| from sugar3.activity import activityinstance | ||
| from sugar4.activity import activityinstance | ||
|
|
||
| activityinstance.main() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -103,7 +103,7 @@ | |
| "dbus", | ||
| "SimpleHTTPServer", | ||
| "socketserver", | ||
| "sugar3", | ||
| "sugar4", | ||
| "cairo", | ||
| ] | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,8 @@ | ||
| src/sugar3/activity/activity.py | ||
| src/sugar3/activity/widgets.py | ||
| src/sugar3/graphics/alert.py | ||
| src/sugar3/graphics/colorbutton.py | ||
| src/sugar3/graphics/objectchooser.py | ||
| src/sugar3/util.py | ||
| src/sugar3/mime.py | ||
| src/sugar3/speech.py | ||
| src/sugar4/activity/activity.py | ||
| src/sugar4/activity/widgets.py | ||
| src/sugar4/graphics/alert.py | ||
| src/sugar4/graphics/colorbutton.py | ||
| src/sugar4/graphics/objectchooser.py | ||
| src/sugar4/util.py | ||
| src/sugar4/mime.py | ||
| src/sugar4/speech.py |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| # We don't care about these string, they are in code which we don't really | ||
| # use and is there solely to not diverge too much from the "upstream" | ||
| # versions of these files. | ||
| src/sugar3/eggdesktopfile.c | ||
| src/sugar3/eggsmclient.c | ||
| src/sugar3/gsm-xsmp.c | ||
| src/sugar4/eggdesktopfile.c | ||
| src/sugar4/eggsmclient.c | ||
| src/sugar4/gsm-xsmp.c | ||
| tests/data/sample.activity/activity.py |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you explain this? We would prefer development mode for testing right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm running this in the live build, and I needed that.
Anyone running in the live build would too.
I haven't tested most of my changes because there's still much that needs to be done to get it to the point where you can see your changes, I've been moving forward by fixing build errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can perhaps have make install-live-build?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That can work.