Handle mark_dependence instruction in AllocBoxToStack #81638
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will not be cherry-picked to release/6.2. |
|
@swift-ci test |
atrick
reviewed
Jul 2, 2025
| @@ -739,6 +746,14 @@ static bool rewriteAllocBoxAsAllocStack(AllocBoxInst *ABI) { | |||
| continue; | |||
| } | |||
|
|
|||
| if (auto *oldMDI = dyn_cast<MarkDependenceInst>(User)) { | |||
| auto *newMDI = SILBuilderWithScope(oldMDI).createMarkDependence( | |||
| oldMDI->getLoc(), oldMDI->getValue(), StackBox, | |||
There was a problem hiding this comment.
Maybe need to replace the value instead of the mark_dependence base. And would be worth checking the replacement in the unit test.
|
You need to make this change in |
|
#82853 addresses this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Permit uses of alloc_box as base operand in a mark_dependence instruction in the AllocBoxToStack optimization.
rdar://150398673