Update SwiftCompilerSources AllocBoxToStack to handle mark_dep. #82853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is updated from Meghana's PR |
|
I'm not merging this until I figure out what strategy to pursue for the 6.2 branch |
atrick
force-pushed
the
boxtostack-markdep
branch
from
deeb9b1 to
9264e7a
Compare
atrick
force-pushed
the
boxtostack-markdep
branch
from
9264e7a to
0c7ad76
Compare
Handle the easy case in which the promoted box is the base operand of a mark_dep. This requires nothing more than setting the base operand to the new stack address. Required for move-only checking. Otherwise, we get an incredibly bizarre compiler error: noncopyable 'foo' cannot be consumed when captured by an escaping closure Fixes rdar://150398673 ([nonescapable] allocbox-to-stack fails causing lifetime diagnostics to fail)
Handle the easy case in which the promoted box is the base operand of a mark_dep. This requires nothing more than setting the base operand to the new stack address. Required for move-only checking. Otherwise, we get an incredibly bizarre compiler error: noncopyable 'foo' cannot be consumed when captured by an escaping closure The legacy pass was updated first for 6.2.
Make the actual errors more obvious in the trace output since diagnostics messages are not printed in-line with tracing.
atrick
force-pushed
the
boxtostack-markdep
branch
from
0c7ad76 to
a281754
Compare
eeckstein
approved these changes
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix AllocBoxToStack to handle mark_dependence[_addr]
Handle the easy case in which the promoted box is the base operand of a
mark_dep. This requires nothing more than setting the base operand to the new
stack address.
Required for move-only checking. Otherwise, we get an incredibly bizarre
compiler error: noncopyable 'foo' cannot be consumed when captured by an
escaping closure
Fixes rdar://150398673 ([nonescapable] allocbox-to-stack fails causing lifetime diagnostics to fail)
Update SwiftCompilerSources AllocBoxToStack to handle mark_dep.
Handle the easy case in which the promoted box is the base operand of a
mark_dep. This requires nothing more than setting the base operand to the new
stack address.
Required for move-only checking. Otherwise, we get an incredibly bizarre
compiler error: noncopyable 'foo' cannot be consumed when captured by an
escaping closure
The legacy pass was updated first for 6.2.