Skip to content

Conversation

@MolloKhan
Copy link

Q A
Bug fix? no
New feature? yes
Docs? no
Issues Fix #857
License MIT

I gave this a second thought, and I think @OskarStark idea is the way to go (#857 (comment))
If the ID coming from the store is in Uuid format the user will likely cast it themself

If you are ok with my changes, I'll proceed to update all the places where VectorDocuments are instantiated

@carsonbot carsonbot added Feature New feature Store Issues & PRs about the AI Store component Status: Needs Review labels Nov 14, 2025
@chr-hertel
Copy link
Member

that should also be changed in TextDocument than, right?

@MolloKhan
Copy link
Author

I think this is it

Copy link
Member

@chr-hertel chr-hertel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One issue we have now is for users not using the Uid component but receiving Uuid instances even if they used string before.

I think the best solution here is to just drop the dependency to the component. no feature of the component itself - besides the type-declaration - actually needs a Uuid and it was a wrong assumption of mine in the beginning based on starting with Pinecone as store 🙈

@MolloKhan
Copy link
Author

Good thinking. I'd need only to remove the Uuid auto-casting from the constructor, right?

@MolloKhan
Copy link
Author

I removed the Uuid auto-casting and only left the type declaration

@OskarStark OskarStark changed the title [Store] VectorDocument Id Support More Types [Store] Allow id to be int|string|Uuid for VectorDocument and TextDocument Nov 19, 2025
@OskarStark
Copy link
Contributor

Can we simplify something in the demo/ folder? Or not needed?

@chr-hertel
Copy link
Member

Can we simplify something in the demo/ folder? Or not needed?

wouldn't know what, don't think so.

but i think a valid follow up would be to kill UUID dependency in store component

Copy link
Member

@chr-hertel chr-hertel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please rebase this once and have another look at MongoDb, Weaviate, Typesense, Milvus, MariaDb, and Meilisearch?

I think your changes in bridge implementations for removing the Uuid::fromString(...) make sense, but is not done everywhere.

Thanks already @MolloKhan!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature New feature Status: Needs Work Store Issues & PRs about the AI Store component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Store] Allow VectorDocument ID to be a string

4 participants