Skip to content

[Store] Allow id to be int|string|Uuid for VectorDocument and TextDocument #867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

[Store] Allow id to be int|string|Uuid for VectorDocument and TextDocument #867

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
92f2bae
Add Pinecone ManagedStore
MolloKhan Nov 13, 2025
ebc6e0a
id: support more types and cast to uuid
MolloKhan Nov 14, 2025
6701f7d
remove sneaky code
MolloKhan Nov 14, 2025
f2860b8
support more types in TextDocument
MolloKhan Nov 14, 2025
4ab61fa
fix places where VectorDocument is intantiated
MolloKhan Nov 14, 2025
96a2d62
update reference in docs
MolloKhan Nov 14, 2025
f9d44eb
fix Pinecone store
MolloKhan Nov 14, 2025
ab54367
Fix PHP CS
MolloKhan Nov 14, 2025
26c88ed
remove Uuid auto-casting
MolloKhan Nov 18, 2025
c2ae175
fix broken tests
MolloKhan Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/store/src/Document/VectorDocument.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,19 @@
*/
final class VectorDocument
{
public readonly int|string|Uuid $id;

public function __construct(
public readonly Uuid $id,
int|string|Uuid $id,
public readonly VectorInterface $vector,
public readonly Metadata $metadata = new Metadata(),
public readonly ?float $score = null,
) {
if (\is_string($id) && Uuid::isValid($id)) {
$this->id = Uuid::fromString($id);
} else {
$this->id = $id;
}
}

/**
Expand Down
24 changes: 24 additions & 0 deletions src/store/tests/Document/VectorDocumentTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
use PHPUnit\Framework\Attributes\TestDox;
use PHPUnit\Framework\Attributes\TestWith;
use PHPUnit\Framework\TestCase;
use Symfony\AI\Platform\Vector\NullVector;
use Symfony\AI\Platform\Vector\Vector;
use Symfony\AI\Store\Document\Metadata;
use Symfony\AI\Store\Document\VectorDocument;
Expand All @@ -25,6 +26,29 @@
*/
final class VectorDocumentTest extends TestCase
{
#[TestWith([1])]
#[TestWith(['id'])]
#[TestWith(['uuid'])]
public function testConstructorIdSupportsManyTypes(int|string $id)
{
if ('uuid' === $id) {
$id = Uuid::v4();
}

$document = new VectorDocument($id, new NullVector());

$this->assertSame($id, $document->id);
}

#[TestDox('Automatically convert strings in UUID format to Uuid instances')]
public function testConstructorConvertIdToUuid()
{
$id = Uuid::v4()->toString();
$document = new VectorDocument($id, new NullVector());

$this->assertInstanceOf(Uuid::class, $document->id);
}

#[TestDox('Creates document with required parameters only')]
public function testConstructorWithRequiredParameters()
{
Expand Down