Initialize harts with zero properly #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
jserv
reviewed
Apr 1, 2025
jserv
reviewed
Apr 1, 2025
jserv
requested changes
Apr 1, 2025
Uninitialized hart_t fields may lead to undefined behavior or startup exceptions. This change replaces malloc with calloc to ensure that all fields are zeroed upon allocation, providing a safer and more consistent initialization. Co-authored-by: Po-Ying Chiu <[email protected]> Reported-by: @testriscv
jserv
changed the title
jserv
changed the title
|
Thank @EricccTaiwan for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uninitialized hart_t fields may lead to undefined behavior or startup exceptions. This change replaces malloc with calloc to ensure that all fields are zeroed upon allocation, providing a safer and more consistent initialization.
Closed : #69
Summary by Bito
This pull request enhances the safety of hart_t instance initialization by replacing malloc with calloc, ensuring all fields are zero-initialized upon allocation. This change addresses potential undefined behavior and improves consistency.Unit tests added: False
Estimated effort to review (1-5, lower is better): 2 - The changes are straightforward and primarily focus on memory allocation safety, making the review process relatively simple.