FIX: plugin declaration can be overwitten. #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Problems** When `jetpack#add` is called with same name's plugin, it checks against `a:plugin` that may inclues GitHub user name such as `tani/jetpack`, but key for `s:declared_packages` is plugin name such as `jetpack`, which is inconsistent. Due to this issue, when the Lua API is used with `requires`, for example, it calls same plugin name to `use(req)` call at line around 853, which may override already declared plugin. **Solution** Use plugin name always for `s:declared_packages`. This patch also includes minor indent fix.
|
Thank you so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problems
When
jetpack#addis called with same name's plugin, it checks againsta:pluginthat may inclues GitHub user name such astani/jetpack, but key fors:declared_packagesis plugin name such asjetpack, which is inconsistent.Due to this issue, when the Lua API is used with
requires, for example, it calls same plugin name touse(req)call at line around 853, which may override already declared plugin.Solution
Use plugin name always for
s:declared_packages.This patch also includes minor indent fix.