Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: plugin declaration can be overwitten. #127

Merged
merged 1 commit into from
Nov 15, 2023

Commits on Nov 14, 2023

  1. FIX: plugin declaration can be overwitten.

    **Problems**
    
    When `jetpack#add` is called with same name's plugin,
    it checks against `a:plugin` that may inclues GitHub user name
    such as `tani/jetpack`, but key for `s:declared_packages` is
    plugin name such as `jetpack`, which is inconsistent.
    
    Due to this issue, when the Lua API is used with `requires`,
    for example, it calls same plugin name to `use(req)` call
    at line around 853, which may override already declared plugin.
    
    **Solution**
    
    Use plugin name always for `s:declared_packages`.
    This patch also includes minor indent fix.
    niw committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    20cad26 View commit details
    Browse the repository at this point in the history