client: enhance waiting methods

[drewdzzz]

Enhancement of waiting methods.
See the commits for details.

Closes #109
Closes #111
Closes #128

[drewdzzz]

Ignoring clang-format suggestions - I stick to the old style in the functions I patch in order to reduce diff.

The suggestion

diff --git a/src/Client/Connector.hpp b/src/Client/Connector.hpp
index bcaa03f..fd8bfb0 100644
--- a/src/Client/Connector.hpp
+++ b/src/Client/Connector.hpp
@@ -74,12 +74,10 @@ public:
 	int connect(Connection<BUFFER, NetProvider> &conn,
 		    const std::string& addr, unsigned port);
 
-	int wait(Connection<BUFFER, NetProvider> &conn, rid_t future,
-		 int timeout = -1, Response<BUFFER> *result = nullptr);
-	int waitAll(Connection<BUFFER, NetProvider> &conn,
-		    const std::vector<rid_t > &futures, int timeout = -1);
-	int waitCount(Connection<BUFFER, NetProvider> &conn,
-		      size_t feature_count, int timeout = -1);
+	int wait(Connection<BUFFER, NetProvider> &conn, rid_t future, int timeout = -1,
+		 Response<BUFFER> *result = nullptr);
+	int waitAll(Connection<BUFFER, NetProvider> &conn, const std::vector<rid_t> &futures, int timeout = -1);
+	int waitCount(Connection<BUFFER, NetProvider> &conn, size_t feature_count, int timeout = -1);
 	std::optional<Connection<BUFFER, NetProvider>> waitAny(int timeout = -1);
 	////////////////////////////Service interfaces//////////////////////////
 	void readyToDecode(const Connection<BUFFER, NetProvider> &conn);
@@ -209,8 +207,7 @@ Connector<BUFFER, NetProvider>::wait(Connection<BUFFER, NetProvider> &conn,
 		return -1;
 	}
 	if (! conn.futureIsReady(future)) {
-		LOG_DEBUG("Connection has been timed out: future ", future,
-			  " is not ready");
+		LOG_DEBUG("Connection has been timed out: future ", future, " is not ready");
 		return -1;
 	}
 	LOG_DEBUG("Feature ", future, " is ready and decoded");
@@ -307,8 +304,7 @@ Connector<BUFFER, NetProvider>::waitCount(Connection<BUFFER, NetProvider> &conn,
 		LOG_ERROR("Connection got an error: ", conn.getError().msg);
 		return -1;
 	}
-	LOG_DEBUG("Connection has been timed out: only ",
-		  conn.getFutureCount() - ready_futures, " are ready");
+	LOG_DEBUG("Connection has been timed out: only ", conn.getFutureCount() - ready_futures, " are ready");
 	return -1;
 }
 
diff --git a/src/Utils/Timer.hpp b/src/Utils/Timer.hpp
index 3d3888a..a97d808 100644
--- a/src/Utils/Timer.hpp
+++ b/src/Utils/Timer.hpp
@@ -40,7 +40,7 @@ public:
 	}
 	bool isExpired() const
 	{
-		if (m_Timeout == std::chrono::milliseconds{-1})
+		if (m_Timeout == std::chrono::milliseconds {-1})
 			return false;
 		std::chrono::time_point<std::chrono::steady_clock> end =
 			std::chrono::steady_clock::now();
@@ -50,7 +50,7 @@ public:
 	}
 	int elapsed() const
 	{
-		if (m_Timeout == std::chrono::milliseconds{-1})
+		if (m_Timeout == std::chrono::milliseconds {-1})
 			return 0;
 		std::chrono::time_point<std::chrono::steady_clock> end =
 			std::chrono::steady_clock::now();

[CuriousGeorgiy]

LGTM.

Dropped some thoughts about the current state of the API. Also, it's not good that we have active users (customers), and we change the API like this — I think it's high time we should start doing releases and versioning (let's open a ticket for this).

If you agree, please open some more tickets.

[drewdzzz]

I think it's high time we should start doing releases and versioning (let's open a ticket for this)

I thought about it, but it seemed to me that the connector is beta so it's OK to change the API significantly.
Well, after you suggested it again, I don't think so - filed #125, let's think about versioning a bit later.

[drewdzzz]

@mkostoevr @CuriousGeorgiy
I found out that the previous implementation didn't poll requests at all with timeout = 0. I pushed the new fixed version.
All the changes are related only to commit client: redesign waiting methods.

UPD: the new two commits are client: handle timeout more safely and client: poll connections on non-blocking wait. Commit client: redesign waiting methods is left intact.