-
-
Notifications
You must be signed in to change notification settings - Fork 368
Handle WorldOption.sav blocking settings on Windows->Linux migration (fixes #886) #910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
NathanFant
wants to merge
2
commits into
thijsvanloef:main
Choose a base branch
from
NathanFant:fix/worldoption-sav-migration-blocks-settings
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,7 +6,17 @@ | |
| > Use this script at your own risk, I am not responsible for dataloss! | ||
| > | ||
| > Please make sure you always have a backup! | ||
|
|
||
|
Check failure on line 9 in migration/README.md
|
||
| > [!IMPORTANT] | ||
| > If you're migrating a save that was ever played on Windows (including via Steam's | ||
| > "host from save data" co-op mode), that save's `WorldOption.sav` takes priority over | ||
| > `PalWorldSettings.ini` and will silently prevent your new server's settings — | ||
| > including `AdminPassword` — from applying. This causes RCON/REST API authentication | ||
| > to fail with "AdminPassword is empty" even when the password is correctly configured | ||
| > everywhere else (see #886). `migrate.sh` (below) handles this automatically by moving | ||
| > any pre-existing `WorldOption.sav` aside; if you migrate manually, do the same | ||
| > yourself (see step 3 in "Manually" below). | ||
|
|
||
| 1. Find a directory which is named by game server name and contains all saved game data, | ||
| usually it will at `~/Steam/steamapps/common/PalServer/Pal/Saved/SaveGames/0/` | ||
| 2. Make sure `migration/migrate.sh`, saved game data directory and mounted volume | ||
|
|
@@ -44,4 +54,9 @@ | |
| DedicatedServerName=`2E85FD38BAA792EB1D4C09386F3A3CDA`. | ||
| 3. Delete the entire new server save at `PalServer\Pal\Saved\SaveGames\0\<your_save_here>`, | ||
| and replace it with the folder from the old server. | ||
| 4. Restart the new server | ||
| 4. If the copied save folder contains a `WorldOption.sav` file and the save was ever played on | ||
| Windows, move (don't delete outright — keep it as a backup) that file out of the way, e.g. | ||
| `mv WorldOption.sav WorldOption.sav.bak`. Otherwise it takes priority over | ||
| `PalWorldSettings.ini` and silently blocks your new server's settings (including | ||
| `AdminPassword`) from applying — see #886. | ||
| 5. Restart the new server | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.