updating default $log dir #158
Merged
+10
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating $log to use path provided at $new instead of defaulting to vitals_log_dir(). Fixes tidyverse#144
simonpcouch
reviewed
Sep 19, 2025
There was a problem hiding this comment.
Thanks so much! I appreciate you spending time with this.
These changes seem reasonable, but I'm a bit too scatter-brained to review thoughtfully at the moment. I'm about to step away from work for the next 3 weeks—I will come back to this once I'm back!
Safe traveling to you on the way home from conf.
simonpcouch
approved these changes
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating $log to use path provided at $new instead of defaulting to vitals_log_dir(). Fixes #144