Skip to content

updating default $log dir #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 6, 2025
Merged

updating default $log dir #158

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6833a45
updating default $log dir
SokolovAnatoliy Sep 19, 2025
a9577dd
note change in NEWS [no ci]
simonpcouch Oct 6, 2025
55c0e6e
Merge branch 'main' into fix-task-log-default-directory
simonpcouch Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions R/task.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,7 @@ Task <- R6::R6Class(
#' @param dir The directory to write the log to.
#'
#' @return The path to the logged file, invisibly.
log = function(dir = vitals_log_dir()) {
log = function(dir = self$dir) {
if (!private$scored) {
cli::cli_abort(
"Task has not been scored yet. Run task$score() first."
Expand Down Expand Up @@ -401,15 +401,10 @@ Task <- R6::R6Class(
)

if (is.na(dir)) {
if (!is.na(self$dir)) {
dir <- self$dir
} else {
dir <- tempdir()
}
self$dir <- tempdir()
}

self$dir <- dir
log_path <- eval_log_write(eval_log, dir = dir)
log_path <- eval_log_write(eval_log, dir = self$dir)

invisible(log_path)
},
Expand Down
2 changes: 1 addition & 1 deletion man/Task.Rd
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading