Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aip_launcher): initialize parameters for new concatenate node #337

Open
wants to merge 5 commits into
base: tier4/universe
Choose a base branch
from

Conversation

vividf
Copy link
Contributor

@vividf vividf commented Oct 30, 2024

This PR introduces a new concatenation algorithm with configurable parameters.

All projects using the concatenation algorithm will need updates to their parameter settings. Additionally, this is a good opportunity to have launch files load parameters from a file rather than hardcoding them in each launcher.

related link:
autowarefoundation/sample_sensor_kit_launch#108

@vividf
Copy link
Contributor Author

vividf commented Oct 30, 2024

xx1 gen1 test

xx1gen1.mp4

@vividf
Copy link
Contributor Author

vividf commented Oct 31, 2024

@Autumn60
As I'm unsure who the maintainer for the X1 project is and noticed you worked on the launcher, I’d like to ask you—or anyone you know who is responsible for the X1 project—to follow the instructions in the provided TIERIV_INTERNAL_LINK

@TomohitoAndo
For the x2 gen1, please also follow the provided TIERIV_INTERNAL_LINK and record a rosbag for verification :)

If possible, we’d like to merge the PR as soon as possible. Thank you!

@vividf
Copy link
Contributor Author

vividf commented Oct 31, 2024

x1 gen2 test

image

@vividf vividf changed the title feat(aip_launcher): initialize parameters for concatenate feat(aip_launcher): initialize parameters for new concatenate node Oct 31, 2024
@Autumn60
Copy link
Contributor

@vividf
Thank you. I will share this PR with other maintainers for X1.
FYI, the representative maintainer for X1 is @1222-takeshi

@vividf vividf marked this pull request as ready for review November 6, 2024 16:01
@vividf vividf requested review from drwnz and Autumn60 November 6, 2024 16:01
@vividf vividf self-assigned this Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants