Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(PandarXT32): fix nebula_node_container.launch.py for PandarXT32 #402

Merged
merged 2 commits into from
Mar 12, 2025

Conversation

TakuIwasaki
Copy link

背景:hesai_ros_wrapper_nodeの起動ができない件があり、nebula_node_container.launch.pyのパラメータが足りてないことでlaunchに失敗していた。
確認方法:nebula_node_container (ここここ) とnebulaのパラメータを比較して足りていないパラメータを修正することでlaunch起動することを確認しました。

@1222-takeshi 1222-takeshi changed the title fix(PandarXT32):fix nebula_node_container.launch.py for PandarXT32 fix(PandarXT32): fix nebula_node_container.launch.py for PandarXT32 Mar 11, 2025
Copy link
Contributor

@1222-takeshi 1222-takeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CIのfailはこのPR起因でないことを確認しました。

@1222-takeshi 1222-takeshi requested a review from kimurariku March 11, 2025 01:53
Copy link
Contributor

@Autumn60 Autumn60 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

パラメータ不足解消ありがとうございます 🙏
LGTM

@Autumn60 Autumn60 merged commit ead0711 into feat/x1/use_xt32_for_top Mar 12, 2025
8 of 10 checks passed
@Autumn60 Autumn60 deleted the fix/x1/nebula_node_container branch March 12, 2025 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants