Skip to content

chore(imu_corrector): Enabled flag for bias scale correction dynamic#670

Open
SergioReyesSan wants to merge 1 commit intotier4:beta/x2/v4.3.1.1from
SergioReyesSan:enabled_bias_scale_correction
Open

chore(imu_corrector): Enabled flag for bias scale correction dynamic#670
SergioReyesSan wants to merge 1 commit intotier4:beta/x2/v4.3.1.1from
SergioReyesSan:enabled_bias_scale_correction

Conversation

@SergioReyesSan
Copy link
Copy Markdown
Contributor

This PR has the updated variables to enable the dynamic bias and scale correction.

For Testing purposes this flags should be enabled, and the drift behaviour should be observed.

Signed-off-by: Sergio Reyes Sanchez <sergioreyes.sanchez@tier4.jp>
@SergioReyesSan SergioReyesSan force-pushed the enabled_bias_scale_correction branch from 748afc4 to 5cab488 Compare February 10, 2026 06:12
@paulsohn
Copy link
Copy Markdown
Contributor

paulsohn commented Feb 10, 2026

@SergioReyesSan

  1. Are you updating this for just beta/x2/v4.3.1.1 or as a permanent one? tier4/universe branch of this branch is no longer maintained as I previously mentioned, but you were unresponsive. If there is any chance that the mainstream will get this update, I would suggest to move relevant aip launchers into autoware_launch.x2 (beta/v4.3.1.1 branch) first, following this example PR https://github.com/tier4/autoware_launch.x2/pull/1888 .
  2. Why are you updating other launchers other than aip_x2_gen2 ?

@paulsohn
Copy link
Copy Markdown
Contributor

@SergioReyesSan One more question:
Why did you opened #669 and then reverted its change on this PR, instead of updating #669 directly?

@SergioReyesSan
Copy link
Copy Markdown
Contributor Author

@paulsohn Sorry for not responding, I submitted 2 versions, enabled or disabled by default, and put it on discussion since i didn't know the plan of SI for testing if they wanted to manually enable or disable the feature, or keep it enabled always. It is still under discussion, but is being tested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants