chore(imu_corrector): Enabled flag for bias scale correction dynamic#670
Open
SergioReyesSan wants to merge 1 commit intotier4:beta/x2/v4.3.1.1from
Open
chore(imu_corrector): Enabled flag for bias scale correction dynamic#670SergioReyesSan wants to merge 1 commit intotier4:beta/x2/v4.3.1.1from
SergioReyesSan wants to merge 1 commit intotier4:beta/x2/v4.3.1.1from
Conversation
Signed-off-by: Sergio Reyes Sanchez <sergioreyes.sanchez@tier4.jp>
748afc4 to
5cab488
Compare
Contributor
|
Contributor
|
@SergioReyesSan One more question: |
Contributor
Author
|
@paulsohn Sorry for not responding, I submitted 2 versions, enabled or disabled by default, and put it on discussion since i didn't know the plan of SI for testing if they wanted to manually enable or disable the feature, or keep it enabled always. It is still under discussion, but is being tested |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has the updated variables to enable the dynamic bias and scale correction.
For Testing purposes this flags should be enabled, and the drift behaviour should be observed.