Make bgw_job_stat_history_errors test more robust #9182
+9
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
claude-fixer[bot] seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
@svenklemm, @fabriziomello: please review this pull request.
|
erimatnor
reviewed
Jan 24, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9182 +/- ##
==========================================
+ Coverage 82.46% 82.56% +0.10%
==========================================
Files 245 245
Lines 48069 48043 -26
Branches 12253 12249 -4
==========================================
+ Hits 39639 39668 +29
- Misses 3582 3593 +11
+ Partials 4848 4782 -66 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
erimatnor
approved these changes
Jan 26, 2026
fabriziomello
approved these changes
Jan 27, 2026
The test was failing on macOS because jobs completed too quickly (0.1s sleep) and there weren't enough jobs to reliably hit the worker process limit. With 26 jobs vs 24 max_worker_processes, jobs would complete and free slots before all jobs attempted to start, causing the test to pass when it should fail. Increased the number of test jobs from 26 to 30 and the sleep duration from 0.1 to 1 second. This ensures jobs overlap more significantly in time, holding worker slots longer and making it more likely that some jobs will fail to start due to slot exhaustion, which is the condition the test is designed to verify. Co-Authored-By: Claude <[email protected]>
Add trailing space to line 208 in the expected output file to match the actual test output. The test was failing in CI due to this whitespace mismatch. Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
erimatnor
force-pushed
the
claude-fix/bgw-job-stat-history-errors-20260124-003445
branch
from
11ab3f2 to
5c40d3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR was automatically generated by Claude Code to fix a failing nightly CI test.
Test Fixed
bgw_job_stat_history_errorsWhat Changed
The test was failing on macOS because jobs completed too quickly (0.1s sleep) and there weren't enough jobs to reliably hit the worker process limit. With 26 jobs vs 24 max_worker_processes, jobs would complete and free slots before all jobs attempted to start, causing the test to pass when it should fail. Increased the number of test jobs from 26 to 30 and the sleep duration from 0.1 to 1 second. This ensures jobs overlap more significantly in time, holding worker slots longer and making it more likely that some jobs will fail to start due to slot exhaustion, which is the condition the test is designed to verify.
Co-Authored-By: Claude [email protected]
Disable-check: commit-count