Skip to content

Make bgw_job_stat_history_errors test more robust #9182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erimatnor merged 2 commits into from
Jan 30, 2026
+9 −9
Merged

Make bgw_job_stat_history_errors test more robust #9182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23ae0db
Make bgw_job_stat_history_errors test more robust
Jan 24, 2026
9adb1eb
Fix whitespace in bgw_job_stat_history_errors test output
Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions tsl/test/expected/bgw_job_stat_history_errors.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,11 +188,11 @@ DO
$TEST$
DECLARE
stmt TEXT;
njobs INT := 26;
njobs INT := 30;
BEGIN
RAISE INFO 'Creating % jobs', njobs;
FOR stmt IN
SELECT format('CREATE PROCEDURE custom_job%s(job_id int, config jsonb) LANGUAGE PLPGSQL AS $$ BEGIN PERFORM pg_sleep(0.1); END; $$', i) FROM generate_series(1, njobs) AS i
SELECT format('CREATE PROCEDURE custom_job%s(job_id int, config jsonb) LANGUAGE PLPGSQL AS $$ BEGIN PERFORM pg_sleep(1); END; $$', i) FROM generate_series(1, njobs) AS i
LOOP
EXECUTE stmt;
END LOOP;
Expand All @@ -202,8 +202,8 @@ BEGIN
FROM generate_series(1, njobs) AS i;
END;
$TEST$;
INFO: Creating 26 jobs
INFO: Scheduling 26 jobs
INFO: Creating 30 jobs
INFO: Scheduling 30 jobs
SELECT _timescaledb_functions.restart_background_workers();
restart_background_workers
----------------------------
Expand All @@ -213,14 +213,14 @@ SELECT _timescaledb_functions.restart_background_workers();
DO
$TEST$
DECLARE
njobs INT := 26;
njobs INT := 30;
BEGIN
RAISE INFO 'Waiting for the % jobs to run', njobs;
SET LOCAL client_min_messages TO WARNING;
PERFORM test.wait_for_job_to_run_or_fail(id) FROM _timescaledb_catalog.bgw_job WHERE id >= 1000;
END;
$TEST$;
INFO: Waiting for the 26 jobs to run
INFO: Waiting for the 30 jobs to run
SELECT count(*) > 0 FROM timescaledb_information.job_history WHERE succeeded IS FALSE AND err_message ~ 'failed to start job';
?column?
----------
Expand Down
6 changes: 3 additions & 3 deletions tsl/test/sql/bgw_job_stat_history_errors.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,11 +125,11 @@ DO
$TEST$
DECLARE
stmt TEXT;
njobs INT := 26;
njobs INT := 30;
BEGIN
RAISE INFO 'Creating % jobs', njobs;
FOR stmt IN
SELECT format('CREATE PROCEDURE custom_job%s(job_id int, config jsonb) LANGUAGE PLPGSQL AS $$ BEGIN PERFORM pg_sleep(0.1); END; $$', i) FROM generate_series(1, njobs) AS i
SELECT format('CREATE PROCEDURE custom_job%s(job_id int, config jsonb) LANGUAGE PLPGSQL AS $$ BEGIN PERFORM pg_sleep(1); END; $$', i) FROM generate_series(1, njobs) AS i
LOOP
EXECUTE stmt;
END LOOP;
Expand All @@ -146,7 +146,7 @@ SELECT _timescaledb_functions.restart_background_workers();
DO
$TEST$
DECLARE
njobs INT := 26;
njobs INT := 30;
BEGIN
RAISE INFO 'Waiting for the % jobs to run', njobs;
SET LOCAL client_min_messages TO WARNING;
Expand Down
Loading