refactor(typescript): refactor to ts (fixes #56) #100
Conversation
There was a problem hiding this comment.
Woah! Thank you SOOOOOO much for doing this porting work!
I'll also cc @surma again here, since it touches a lot of their code they implemented. But! I think you and I can handle this for the most part.
If you don't mind me asking, after doing the port, have you tried using the library from a non TS app? Like do all the same quick start examples and things work? 😄 I can test that if you would like!
Let me know when you feel this PR is ready, I can do some testing on my end, and I think we can start considering merging this! Again, thank you SOOOOO much for doing this! 😄 🎉
| export function getAscToJsConverterForType(typeName) { | ||
| return getConverterForType(typeName)?.ascToJs; | ||
| export function getAscToJsConverterForType(typeName: string) { | ||
| return getConverterForType(typeName).ascToJs; |
There was a problem hiding this comment.
Are we sure that the typescript typings will remove the need for the ? 😄
There was a problem hiding this comment.
This was not needed before as well as getConverterForType always returns a non nullish value.
Actualy I did not use it in a TS app 😉 only a simple JS Only type missmatch I could think of is in Lines 3 to 7 in 3ff4b1d |
Ready for review. |
Sounds good to me! 😄
Yay! Awesome, thank you! 😄 🎉
Awesome! So since there wasn't any changes since the last time I looked at the code, I am going to approve and merge! 😄 |
|
@mathe42 I am going to merge in all your changes, and then cut a minor release after I review and merge all of your code 😄 |
I wanted a look at the complete libary and took the chance to rewrite it to TS.
Can be optimized (for example TS-Strict mode is a good idea). But this results in a lot of errors.