Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TWE-44 | Front end fine-tuning #372

Merged
merged 15 commits into from
Mar 7, 2025
Merged

Conversation

shyusu4
Copy link
Collaborator

@shyusu4 shyusu4 commented Mar 4, 2025

Link to Ticket

Description of Changes Made

  • Remove all dates from case study pages
  • Remove all filter tags from blogs index, blogs listing, and blog detail page
  • Increase the speed of the dynamic hero and remove the touch interaction functionality on mobile (it was blocking the user from scrolling down the page)
  • Lazy load images on the home page division signpost cards
  • Modify navigation styles:
    • Add hover styles to primary navigation to match the design
    • Fix an issue where the arrow icons in the secondary submenu navigation remained visible when closing the menu
  • General styling tweaks:
    • Add bottom margin to the header on the icon keypoints block
    • Make the font size smaller for the featured services cards button link
    • Add the primary theme color to textual stats
    • Change the footer cta heading to a motif heading (plain white on the home page)

How to Test

Navigate throughout your local build and view the relevant components.

Screenshots

Expand to see more

MR Checklist

  • Add a description of your pull request and instructions for the reviewer to verify your work.
  • If your pull request is for a specific ticket, link to it in the description.
  • Stay on point and keep it small so the merge request can be easily reviewed.
  • Tests and linting passes.

Unit tests

  • Added
  • Not required

Documentation

Browser testing

  • I have tested in the following browsers and environments (edit the list as required)
    • Latest version of Chrome on mac
    • Latest version of Firefox on mac
    • Latest version of Safari on mac
    • Safari on last two versions of iOS
    • Chrome on last two versions of Android
  • Not required

Data protection

  • Not relevant
  • This adds new sources of PII and documents it and modifies Birdbath processors accordingly

Light and dark mode

  • I have tested the changes in both light and dark mode
  • The change is not relevant to dark and light mode

Accessibility

  • Automated WCAG 2.1 tests pass
  • HTML validation passes
  • Manual WCAG 2.1 tests completed
  • I have tested in a screen reader
  • I have tested in high-contrast mode
  • Any animations removed for prefers-reduced-motion
  • Not required

Sustainability

  • Images are optimised and lazy-loading used where appropriate
  • SVGs have been optimised
  • Perfomance and transfer of data considered
  • If JavaScript is needed alternatives have been considered
  • Not required

Pattern library

  • The pattern library component for this template displays correctly, and does not break parent templates
  • The styleguide is updated if relevant
  • Changes are not relevant the pattern library

Sorry, something went wrong.

@shyusu4 shyusu4 changed the title Fix/fe tweaks TWE-44 | Front end fine-tuning Mar 5, 2025
@shyusu4 shyusu4 marked this pull request as ready for review March 5, 2025 13:50
@SharmaineLim
Copy link
Collaborator

Had a poke around:

Post dates

✅ Work pages do not display the post dates
✅ Historic work pages do not display the post dates
✅ Work index pages do not display the post dates on the results

Tags in the blogs

✅ Blog listing page does not display tags as filter options
✅ Blog listing page does not display tags on the results
Blog post page still displays the tags (I checked with Lisa, we want to hide these too)

Others

✅ Margin & styling restored to the keypoints with icons block's heading (looks ok with intro also)
✅ Featured services block heading & intro look consistent
✅ Person page intro aligned with content
✅ Dynamic hero changes faster

Looking good! Thanks, Sherry :)

@shyusu4
Copy link
Collaborator Author

shyusu4 commented Mar 6, 2025

thank you for taking a look at this, @SharmaineLim! I've now removed the tags for the blog post pages too :)

@shyusu4 shyusu4 requested a review from chris-lawton March 7, 2025 09:49
Copy link
Member

@chris-lawton chris-lawton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shyusu4 - updated changes look good!

@shyusu4 shyusu4 merged commit 2d7b425 into integration/2024-evolution Mar 7, 2025
4 checks passed
@shyusu4 shyusu4 deleted the fix/fe-tweaks branch March 7, 2025 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants