Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TWE-44 | Front end fine-tuning #372

Merged
merged 15 commits into from
Mar 7, 2025
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add smaller font to compact button link variant, add color theme to t…
…ext stats, tweak secondary nav styles
shyusu4 committed Mar 6, 2025
commit b85bb2d5515a688aacf9bcda43ef59407006eeaa
Original file line number Diff line number Diff line change
@@ -22,7 +22,7 @@ <h2 class="heading heading--two division-signpost__heading">{% firstof card.head
class="button-link button-link--{{ card.card_colour }}"
{% if card.accessible_link_text %}aria-label="{{ card.accessible_link_text }}"{% endif %}
>
{{ card.link_text }}&nbsp;{% include "patterns/atoms/icons/icon.html" with name="arrow-wide" classname="button-link__arrow" %}
{{ card.link_text }}<span class="button-link__tail">&nbsp;{% include "patterns/atoms/icons/icon.html" with name="arrow-wide" classname="button-link__arrow" %}</span>
</a>
</li>
{% endfor %}
Original file line number Diff line number Diff line change
@@ -22,7 +22,7 @@ <h3 class="featured-services__heading heading heading--two-b">{% firstof card.he
class="button-link button-link--compact"
{% if card.accessible_link_text %}aria-label="{{ card.accessible_link_text }}"{% endif %}
>
{{ card.link_text }}&nbsp;{% include "patterns/atoms/icons/icon.html" with name="arrow-wide-sm" classname="button-link__arrow" %}
{{ card.link_text }}<span class="button-link__tail">&nbsp;{% include "patterns/atoms/icons/icon.html" with name="arrow-wide-sm" classname="button-link__arrow" %}</span>
</a>
</li>
{% endfor %}
Original file line number Diff line number Diff line change
@@ -2,7 +2,7 @@
<ul class="stats stats--textual grid__stats">
{% for stat in value %}
<li class="stats__stat">
<span class="stats__text">
<span class="stats__text heading heading--three">
{{ stat.headline_text }}
</span>
{% if stat.further_details %}
7 changes: 7 additions & 0 deletions tbx/static_src/sass/components/_button-link.scss
Original file line number Diff line number Diff line change
@@ -15,6 +15,7 @@

// compact variant of the button with reduced padding
&--compact {
@include font-size('size-five');
padding: 13px $spacer-small;

#{$root}__arrow {
@@ -60,6 +61,12 @@
}
}

&__tail {
// Keep the arrow attached to the last word so it's not orphaned on a new line
white-space: nowrap;
display: inline;
}

&__arrow {
@include arrow-link-icon-styles(
$interaction-color: var(--color--button-link-interaction)
5 changes: 1 addition & 4 deletions tbx/static_src/sass/components/_stats.scss
Original file line number Diff line number Diff line change
@@ -37,13 +37,10 @@
&__number {
color: var(--color--theme-primary);
display: block;
font-weight: $weight--semibold;
}

&__text {
@include font-size(size-three);
font-weight: $weight--semibold;
color: var(--color--heading);
color: var(--color--theme-primary);
display: block;
margin-bottom: $spacer-small;
}
Original file line number Diff line number Diff line change
@@ -51,7 +51,7 @@ Styles for the secondary navigation at desktop (top level)
// wrapper ensures the text doesn't move when the icon changes
&__icon-wrapper {
@include z-index(overlap);
width: 13px;
width: 12px;
position: relative;
display: inline-block;
margin-left: 8px;
@@ -60,9 +60,9 @@ Styles for the secondary navigation at desktop (top level)
// chevron when menu is closed
&__icon-closed {
display: block;
width: 16px;
width: 11px;
height: 11px;
color: var(--color--text);
color: var(--color--heading);
transform: rotate(90deg);

@include high-contrast-light-mode() {
Original file line number Diff line number Diff line change
@@ -132,6 +132,7 @@ Styles for the lower levels of the navigation at desktop
$interaction-color: var(--color--theme-primary)
);
color: var(--color--theme-primary);
vertical-align: text-top;
opacity: 0;

.active & {