Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NAS-132071 / 25.04 / App WebUI does not work after migration #10980

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

NAS-132071 / 25.04 / App WebUI does not work after migration #10980

wants to merge 1 commit into from
+50 −5

Conversation

AlexKarpov98
Copy link
Contributor

Testing: see ticket.

Check WebUI button inside app info card.

@AlexKarpov98 AlexKarpov98 self-assigned this Nov 5, 2024
@AlexKarpov98 AlexKarpov98 requested a review from a team as a code owner November 5, 2024 14:05
@AlexKarpov98 AlexKarpov98 requested review from undsoft and removed request for a team November 5, 2024 14:05
@bugclerk
Copy link
Contributor

bugclerk commented Nov 5, 2024

Jira URL: https://ixsystems.atlassian.net/browse/NAS-132071

@bugclerk bugclerk changed the title NAS-132071: App WebUI does not work after migration NAS-132071 / 25.04 / App WebUI does not work after migration Nov 5, 2024
undsoft
undsoft requested changes Nov 5, 2024
View reviewed changes
Copy link
Collaborator

@undsoft undsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So if the URL is coming from middleware and is incorrect, why not just reassign the ticket to middleware?

@codecov Codecov
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.93%. Comparing base (e453d16) to head (d0c1d7a).
Report is 10 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #10980      +/-   ##
==========================================
- Coverage   81.94%   81.93%   -0.01%     
==========================================
  Files        1609     1609              
  Lines       56677    56698      +21     
  Branches     5867     5869       +2     
==========================================
+ Hits        46443    46456      +13     
- Misses      10234    10242       +8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlexKarpov98 AlexKarpov98 mentioned this pull request Nov 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@undsoft undsoft undsoft requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@AlexKarpov98 AlexKarpov98

Labels
backport-24.10.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexKarpov98 @bugclerk @undsoft