Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Silkscreen Paths cause extra pins in schematic view #308

Closed
seveibar opened this issue Nov 15, 2024 · 2 comments · Fixed by #315
Closed

Silkscreen Paths cause extra pins in schematic view #308

seveibar opened this issue Nov 15, 2024 · 2 comments · Fixed by #315
Labels
💎 Bounty

Comments

@seveibar
Copy link
Contributor

seveibar commented Nov 15, 2024 •
edited
Loading

/bounty $10

Image
@algora-pbc Algora PBC
Copy link

algora-pbc bot commented Nov 15, 2024 •
edited
Loading

💎 $10 bounty • tscircuit

Steps to solve:

  1. Start working: Comment /attempt #308 with your implementation plan
  2. Submit work: Create a pull request including /claim #308 in the PR body to claim the bounty
  3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Thank you for contributing to tscircuit/core!

Add a bounty • Share on socials

Attempt Started (GMT+0) Solution
🟢 @vishwamartur Nov 15, 2024, 7:01:13 PM WIP

@vishwamartur
Copy link

vishwamartur commented Nov 15, 2024 •
edited by algora-pbc bot
Loading

/attempt #308

Options

vishwamartur added a commit to vishwamartur/core that referenced this issue Nov 15, 2024
@vishwamartur
Fix silkscreen paths causing extra pins in schematic view
f62c5ae 
Related to tscircuit#308

Add method to prevent silkscreen paths from being interpreted as pins in schematic view.

* **SilkscreenPath.ts**
  - Add `doInitialSchematicComponentRender` method to `SilkscreenPath` class to prevent silkscreen paths from being interpreted as pins in the schematic view.
* **silkscreenpath.test.tsx**
  - Add test case to verify that silkscreen paths are not interpreted as pins in the schematic view.
@vishwamartur vishwamartur mentioned this issue Nov 15, 2024
Closed
@ShiboSoftwareDev ShiboSoftwareDev mentioned this issue Nov 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💎 Bounty
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixed non-port elements being added as ports for custom footprints ShiboSoftwareDev/core
2 participants
@seveibar @vishwamartur