Skip to content

Fix missing utilities in bootstrap-grid#39068

Closed
MewenLeHo wants to merge 4 commits intotwbs:mainfrom
MewenLeHo:main-mlh-fix-missing-utilities-inside-bootstrap-grid
Closed

Fix missing utilities in bootstrap-grid#39068
MewenLeHo wants to merge 4 commits intotwbs:mainfrom
MewenLeHo:main-mlh-fix-missing-utilities-inside-bootstrap-grid

Conversation

@MewenLeHo
Copy link
Copy Markdown
Contributor

@MewenLeHo MewenLeHo commented Aug 17, 2023

Description

Adding gap, row-gap and column-gap to the list of utilities needed for bootstrap-grip.scss.

Motivation & Context

Allow people using Bootstrap's grid system by importing only bootstrap-grip.scss to have all the spacing utilities needed.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • (NA) My change introduces changes to the documentation
  • (NA) I have updated the documentation accordingly
  • (NA) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

@MewenLeHo MewenLeHo requested a review from a team as a code owner August 17, 2023 14:59
Copy link
Copy Markdown
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say it's logical to add them in bootstrap-grid.css. Thoughts @mdo?

However, https://deploy-preview-39068--twbs-bootstrap.netlify.app/docs/5.3/getting-started/contents/#css-files probably needs to be modified because "Only flex utilities" isn't true since we also have "Margin and padding" and "Gap" utilities from Spacing.

@mdo
Copy link
Copy Markdown
Member

mdo commented Mar 13, 2026

Resolved in v6 in #42172.

@mdo mdo closed this Mar 13, 2026
@github-project-automation github-project-automation Bot moved this from Needs review to Done in v5.4.0 Mar 13, 2026
@mdo mdo removed this from v5.4.0 Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants