Use byte_size for correct lengths and offsets#13
Open
jbowtie wants to merge 1 commit intotyre:masterfrom
Open
Conversation
Author
|
Note that this will not build on Travis due to #12 but can be built and checked locally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces several usages of String.length with byte_size to ensure that correct lengths and offsets are written out.
Without this fix several PDF readers will flag the generated PDF as corrupt and may refuse to display more complex documents. The command-line tools for muPDF are good for validating output (as well as inspecting and dumping the PDF objects).