Skip to content

Use byte_size for correct lengths and offsets #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jbowtie wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use byte_size for correct lengths and offsets #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions lib/gutenex/pdf/exporter.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,7 @@ defmodule Gutenex.PDF.Exporter do
alias Gutenex.PDF.RenderContext
alias Gutenex.PDF.Serialization
# Declare the PDF version
@start_mark """
%PDF-1.7
"""
@start_mark "%PDF-1.7\n"
@end_mark "%%EOF\r\n"

def export(%RenderContext{}=render_context) do
Expand All @@ -28,7 +26,7 @@ defmodule Gutenex.PDF.Exporter do
end

def cross_reference_table(serialized_objects) do
pdf_start_position = String.length(@start_mark)
pdf_start_position = byte_size(@start_mark)
{xrefs, _acc} = :lists.mapfoldl &xref/2, pdf_start_position, serialized_objects
"""
xref
Expand All @@ -38,8 +36,8 @@ defmodule Gutenex.PDF.Exporter do
end

def start_cross_reference(serialized_objects) do
total_length = Enum.reduce serialized_objects, String.length(@start_mark), fn (object, total) ->
String.length(object) + total
total_length = Enum.reduce serialized_objects, byte_size(@start_mark), fn (object, total) ->
byte_size(object) + total
end

"""
Expand All @@ -49,7 +47,7 @@ defmodule Gutenex.PDF.Exporter do
end

def xref(serialized_objects, position) do
objects_length = String.length(serialized_objects)
objects_length = byte_size(serialized_objects)
{xref1(position, "00000 n"), position + objects_length}
end

Expand Down