Prepare cinnamon theme variants #3842

hsbasu · 2023-03-15T14:51:40Z

set cinnamon component option to true
add colorable assets file
Update the meson build script to create variants
Follow the way gnome-shell variants are created
Not using directories cinnamon, cinnamon-dark, dark and default. Can be cleaned up later.

hsbasu · 2023-03-15T14:57:57Z

Hi @Jupi007 The PR for cinnamon variants you requested. Please have a look. Looking at this, I think we should merge #3639 here. Because, we don't know when debian will merge my PR.

Initu-Castilhos · 2023-03-16T06:46:17Z

The light version has a lot of contrast between the separator and the corner bar.

The dark version is ok.

The checked and radio are 24px and the radio is light in the dark version. Take a look at this P.R. done: #3794

Jupi007

Hi @hsbasu and thanks a lot for this PR!
This is much appreciated ❤️

I added some requested change.

meson_options.txt

test-yaru

cinnamon-shell/src/sass/_tweaks.scss

cinnamon-shell/src/assets/colorable-assets/checkbox/radio-unchecked.svg

cinnamon-shell/src/assets/colorable-assets/checkbox/checkbox-checked-focused.svg

cinnamon-shell/meson.build

Jupi007 · 2023-03-16T09:14:20Z

The light version has a lot of contrast between the separator and the corner bar.

@Initu-Castilhos Is this problem reproducible in master, or only in this PR?

Jupi007 · 2023-03-16T15:07:49Z

@hsbasu Thanks a lot to have applied my requested changes 🙂
I don't know why, but it looks like you messed up the commits because some of my previous PRs changes pop up here 🤔

@Initu-Castilhos Can you retest this PR, please?
I need to setup a cinnamon VM, but it could be nice to have a quicker feedback, especially for the separator problem.

Initu-Castilhos · 2023-03-16T15:09:56Z

@hsbasuMuito obrigado por ter aplicado minhas alterações solicitadas🙂 Não sei por que, mas parece que você estragou os commits porque algumas das minhas alterações anteriores de PRs apareceram aqui🤔

@Initu-CastilhosVocê pode testar novamente este PR, por favor? Preciso configurar uma VM canela, mas seria bom ter um feedback mais rápido, especialmente para o problema do separador.
👍🏼

Initu-Castilhos · 2023-03-16T15:27:52Z

A versão light tem muito contraste entre o separador e a barra de canto.

@Initu-CastilhosEste problema é reproduzível em master, ou apenas neste PR?

Master.

hsbasu · 2023-03-16T15:30:53Z

@hsbasu Thanks a lot to have applied my requested changes 🙂
I don't know why, but it looks like you messed up the commits because some of my previous PRs changes pop up here 🤔

@Initu-Castilhos Can you retest this PR, please?
I need to setup a cinnamon VM, but it could be nice to have a quicker feedback, especially for the separator problem.

Yes I know. Give me some time. I'll repush it. Please don't merge yet.

Initu-Castilhos · 2023-03-16T15:39:55Z

@hsbasuMuito obrigado por ter aplicado minhas alterações solicitadas ligeiramente_smiling_face
Não sei por que, mas parece que você estragou os commits porque algumas das minhas alterações anteriores de PRs apareceram aqui pensando
@Initu-CastilhosVocê pode testar novamente este PR, por favor?
Preciso configurar uma VM canela, mas seria bom ter um feedback mais rápido, especialmente para o problema do separador.

Sim eu sei. Me dê um tempo. Vou repô-lo. Por favor, não mescle ainda.

The problem still exists.

Initu-Castilhos · 2023-03-16T15:52:14Z

It's not coloring.

Initu-Castilhos · 2023-03-16T18:05:27Z

Maybe it's better to change the color of the panel and base it on the titlebar color like in Mint-Y. I think this makes it better to maintain the theme.

- set cinnamon component option to true - add colorable assets file - Update the meson build script to create variants - Follow the way gnome-shell variants are created - Remove unnecessary directories in cinnamon-shell: cinnamon, cinnamon-dark, dark and default.

hsbasu · 2023-03-16T18:40:06Z

@Initu-Castilhos @Jupi007 @ItzSwirlz Corrected everything. Please have a look.

Initu-Castilhos · 2023-03-16T19:13:41Z

Nothing yet.

hsbasu · 2023-03-16T19:19:01Z

Nothing yet.

It's strange. I rebased all the scss files from the default folder. I was able to generate all the variants and assets properly. Let me try again.

hsbasu · 2023-03-16T19:45:04Z

@Initu-Castilhos @Jupi007 I get it now. Those colours are coming from the sass files and are not using accent_bg_colour as their base. To modify those colours, the sass files need to be modified. I have cross checked all the colorizable assests are taking accent colour. I would suggest to have a separate commit for them.

Initu-Castilhos · 2023-04-02T22:48:14Z

@Initu-Castilhos @Jupi007Agora eu entendi. Essas cores vêm dos arquivos sass e não estão usando acent_bg_colour como base. Para modificar essas cores, os arquivos sass precisam ser modificados. Eu verifiquei se todos os recursos colorizáveis estão usando cores de destaque. Eu sugeriria ter um commit separado para eles.

I found this project: https://github.com/dgsasha/dg-yaru

This style with floating menu and more rounded corners is very close to gnome-shell.

hsbasu · 2023-05-04T03:48:01Z

@Jupi007 A gentle reminder on the PR.

Jupi007

Hi @hsbasu,
sorry for the late reply.

Imo, this can be merged.
But I would like to have @Muqtxdir approval before.

Muqtxdir

thanks

Jupi007 · 2023-06-16T16:49:30Z

Thanks a lot for this PR @hsbasu 👍
And sorry for the delay.

hsbasu · 2023-06-16T17:03:42Z

@Jupi007 It's ok. Glad to contribute.

Jupi007 · 2023-06-16T17:05:36Z

@hsbasu it is already merged 🙂

Feichtmeier · 2023-06-16T17:05:40Z

:D

hsbasu · 2023-06-16T17:07:01Z

😁 didn't see that it's already merged. Good work everyone.

Initu-Castilhos · 2023-06-16T21:20:02Z

It does not complete the installation.

Jupi007 · 2023-06-17T09:21:57Z

@Initu-Castilhos I did a fix PR here: #3921
Can you test it?

hsbasu force-pushed the cinnamon-add-variants branch from 8af3dc6 to eab4689 Compare March 15, 2023 14:54

Jupi007 requested changes Mar 16, 2023

View reviewed changes

Jupi007 requested a review from Muqtxdir March 16, 2023 09:13

Jupi007 added Area: cinnamon Area: Accent Colors labels Mar 16, 2023

hsbasu force-pushed the cinnamon-add-variants branch from efd36dc to 5fee171 Compare March 16, 2023 18:37

Jupi007 approved these changes May 5, 2023

View reviewed changes

Jupi007 requested review from Muqtxdir and removed request for Muqtxdir June 11, 2023 19:11

Muqtxdir approved these changes Jun 16, 2023

View reviewed changes

Jupi007 merged commit 2ac8839 into ubuntu:master Jun 16, 2023

hsbasu deleted the cinnamon-add-variants branch June 16, 2023 21:01

hsbasu mentioned this pull request Jun 18, 2023

Cinnamon-light theme colors issues. #3922

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Prepare cinnamon theme variants #3842

Prepare cinnamon theme variants #3842

hsbasu commented Mar 15, 2023

hsbasu commented Mar 15, 2023 •

edited

Loading

Initu-Castilhos commented Mar 16, 2023

Jupi007 left a comment

Jupi007 commented Mar 16, 2023 •

edited

Loading

Jupi007 commented Mar 16, 2023

Initu-Castilhos commented Mar 16, 2023

Initu-Castilhos commented Mar 16, 2023

hsbasu commented Mar 16, 2023

Initu-Castilhos commented Mar 16, 2023

Initu-Castilhos commented Mar 16, 2023

Initu-Castilhos commented Mar 16, 2023 •

edited

Loading

hsbasu commented Mar 16, 2023

Initu-Castilhos commented Mar 16, 2023

hsbasu commented Mar 16, 2023

hsbasu commented Mar 16, 2023 •

edited

Loading

Initu-Castilhos commented Apr 2, 2023 •

edited

Loading

hsbasu commented May 4, 2023

Jupi007 left a comment

Muqtxdir left a comment

Jupi007 commented Jun 16, 2023

hsbasu commented Jun 16, 2023 •

edited

Loading

Jupi007 commented Jun 16, 2023

Feichtmeier commented Jun 16, 2023

hsbasu commented Jun 16, 2023 •

edited

Loading

Initu-Castilhos commented Jun 16, 2023

Jupi007 commented Jun 17, 2023

Prepare cinnamon theme variants #3842

Prepare cinnamon theme variants #3842

Conversation

hsbasu commented Mar 15, 2023

hsbasu commented Mar 15, 2023 • edited Loading

Initu-Castilhos commented Mar 16, 2023

Jupi007 left a comment

Choose a reason for hiding this comment

Jupi007 commented Mar 16, 2023 • edited Loading

Jupi007 commented Mar 16, 2023

Initu-Castilhos commented Mar 16, 2023

Initu-Castilhos commented Mar 16, 2023

hsbasu commented Mar 16, 2023

Initu-Castilhos commented Mar 16, 2023

Initu-Castilhos commented Mar 16, 2023

Initu-Castilhos commented Mar 16, 2023 • edited Loading

hsbasu commented Mar 16, 2023

Initu-Castilhos commented Mar 16, 2023

hsbasu commented Mar 16, 2023

hsbasu commented Mar 16, 2023 • edited Loading

Initu-Castilhos commented Apr 2, 2023 • edited Loading

hsbasu commented May 4, 2023

Jupi007 left a comment

Choose a reason for hiding this comment

Muqtxdir left a comment

Choose a reason for hiding this comment

Jupi007 commented Jun 16, 2023

hsbasu commented Jun 16, 2023 • edited Loading

Jupi007 commented Jun 16, 2023

Feichtmeier commented Jun 16, 2023

hsbasu commented Jun 16, 2023 • edited Loading

Initu-Castilhos commented Jun 16, 2023

Jupi007 commented Jun 17, 2023

hsbasu commented Mar 15, 2023 •

edited

Loading

Jupi007 commented Mar 16, 2023 •

edited

Loading

Initu-Castilhos commented Mar 16, 2023 •

edited

Loading

hsbasu commented Mar 16, 2023 •

edited

Loading

Initu-Castilhos commented Apr 2, 2023 •

edited

Loading

hsbasu commented Jun 16, 2023 •

edited

Loading

hsbasu commented Jun 16, 2023 •

edited

Loading