Support CRLF BLIF files and expose string parser#1
Open
benjaminwp18 wants to merge 7 commits intoucb-bar:mainfrom
Open
Support CRLF BLIF files and expose string parser#1benjaminwp18 wants to merge 7 commits intoucb-bar:mainfrom
benjaminwp18 wants to merge 7 commits intoucb-bar:mainfrom
Conversation
joonho3020
reviewed
Feb 1, 2026
src/parser.rs
Outdated
| }; | ||
|
|
||
| const MODULE_END_UNIX: &'static str = "\n.end\n"; | ||
| const MODULE_END_WINDOWS: &'static str = "\r\n.end\r\n"; |
Contributor
There was a problem hiding this comment.
It is undesirable to have global constants embedded in the file.
Author
There was a problem hiding this comment.
Replaced with local constants; only used in one function
Contributor
|
Author
|
Looks like the hang was just very slow parsing; removing my |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows, YOSYS generates BLIF files with CRLF line endings. blif-parser currently errors on CRLF line endings. This PR:
I'd be happy to make changes if anyone sees this and has feedback!