-
Notifications
You must be signed in to change notification settings - Fork 1
Support CRLF BLIF files and expose string parser #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
benjaminwp18
wants to merge
7
commits into
ucb-bar:main
Choose a base branch
from
benjaminwp18:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
36f53a5
Add multiple module + CRLF test
benjaminwp18 4e089eb
Parse BLIFs with CRLF line endings
benjaminwp18 64dbccb
Cleanup
benjaminwp18 3761156
Expose string parser
benjaminwp18 fd328c9
Merge branch 'ucb-bar:main' into main
benjaminwp18 2e94711
Make constants local & parsing function private
benjaminwp18 2539867
Remove slow & unnecessary branched parser
benjaminwp18 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| tests/AdderTwoMod.blif eol=crlf |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| # Generated by Yosys 0.59+134 (git sha1 9871e9b17, x86_64-w64-mingw32-g++ 13.2.1 -O3) | ||
|
|
||
| .model full_add | ||
| .inputs a b cin | ||
| .outputs sum cout | ||
| .names $false | ||
| .names $true | ||
| 1 | ||
| .names $undef | ||
| .subckt OR A=y B=z Y=cout | ||
| .subckt half_add a=a b=b c=y s=x | ||
| .subckt half_add a=x b=cin c=z s=sum | ||
| .end | ||
|
|
||
| .model half_add | ||
| .inputs a b | ||
| .outputs s c | ||
| .names $false | ||
| .names $true | ||
| 1 | ||
| .names $undef | ||
| .subckt AND A=a B=b Y=c | ||
| .subckt XOR A=a B=b Y=s | ||
| .end |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is undesirable to have global constants embedded in the file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replaced with local constants; only used in one function