riscv: gate D-width atomic translators on the A extension - #2395
Open
carlosqwqqwq wants to merge 2 commits into
Open
riscv: gate D-width atomic translators on the A extension#2395carlosqwqqwq wants to merge 2 commits into
carlosqwqqwq wants to merge 2 commits into
Conversation
carlosqwqqwq
force-pushed
the
fix/riscv-dwidth-atomic-a-gate
branch
from
August 29, 2026 07:24
7712a39 to
38ee5e0
Compare
Author
|
Thank you very much for taking the time to review this PR. We have rebased it onto dev and applied the extension check consistently to the D-width atomic translators, with focused validation of the affected behavior. Could you please let us know what further code, test, or PR changes you would recommend? We will gladly adjust the patch to match the project guidelines. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2389
Problem
The eleven RV64 D-width atomic translators in
trans_rva.inc.c(trans_lr_d,trans_sc_d,trans_amoswap_d,trans_amoadd_d,trans_amoxor_d,trans_amoand_d,trans_amoor_d,trans_amomin_d,trans_amomax_d,trans_amominu_d,trans_amomaxu_d) emit their memory operations without theREQUIRE_EXT(ctx, RVA)check that every W-width sibling performs, so they retire and modify memory on harts without A instead of raising an illegal-instruction exception.Change
Add
REQUIRE_EXT(ctx, RVA);as the first statement of each of the eleven D-width translators. The check traps at the first D-width atomic before any memory effect, matching the W-width translators and upstream QEMU. The focused unit test istest_riscv64_dwidth_atomic_without_aintests/unit/test_riscv.c.Validation
devand built the RISC-V targets.u030suite includes the A-clear profile patch, a D-width witness, and a W-width control.Public reproducer and explicit profile setup:
https://github.com/carlosqwqqwq/unicorn-riscv-repros/tree/main/u030