Skip to content

feat: add IsLiveEditing API #904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 8 commits into from
Closed

feat: add IsLiveEditing API #904

wants to merge 8 commits into from

Conversation

@schinkowski
Copy link
Contributor

@schinkowski schinkowski commented Mar 31, 2023

Adding a way to check whether live editing is active.
Need to merge this first: #903

@sindharta-tanuwijaya sindharta-tanuwijaya changed the title feat: Live edit property [for 0.18.x] feat: Live edit property Apr 3, 2023
sindharta-tanuwijaya
sindharta-tanuwijaya reviewed Apr 3, 2023
View reviewed changes
@schinkowski schinkowski changed the base branch from dev to spline_fixes April 4, 2023 12:29
@schinkowski schinkowski changed the base branch from spline_fixes to instance_parent_fix April 4, 2023 13:20
@sindharta-tanuwijaya sindharta-tanuwijaya changed the title [for 0.18.x] feat: Live edit property feat: add IsLiveEditing API Apr 5, 2023
Base automatically changed from instance_parent_fix to spline_fixes April 6, 2023 03:10
@sindharta-tanuwijaya
Copy link
Collaborator

sindharta-tanuwijaya commented Apr 6, 2023 •
edited
Loading

I think we can merge this API addition to dev (without the spline fixes).
Can you please rebase this against dev ?

@schinkowski schinkowski changed the base branch from spline_fixes to dev April 17, 2023 09:36
@schinkowski schinkowski dismissed sindharta-tanuwijaya’s stale review April 17, 2023 09:36

The base branch was changed.

@sindharta-tanuwijaya
Copy link
Collaborator

sindharta-tanuwijaya commented Apr 18, 2023

@schinkowski
I see the spline fixes is mixed together in this PR.
If we can separate the IsLiveEditing API from it, then it will be possible for us to create a minor release that includes it.

@schinkowski
Copy link
Contributor Author

schinkowski commented Apr 25, 2023

Adding a way to check whether live editing is active.

The other PRs were merged into the wrong branch. I made a new PR for this here: #908

@sindharta-tanuwijaya
Copy link
Collaborator

sindharta-tanuwijaya commented Apr 28, 2023 •
edited
Loading

I think we can close this PR since

  1. IsLiveEditing API changes have been merged
  2. There is another PR for spline fixes.

What do you think ?
@schinkowski

@schinkowski
Copy link
Contributor Author

schinkowski commented Apr 28, 2023

I think we can close this PR since

  1. IsLiveEditing API changes have been merged
  2. There is another PR for spline fixes.

What do you think ? @schinkowski

I guess so, looks like this doesn't have any other changes now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sindharta-tanuwijaya sindharta-tanuwijaya sindharta-tanuwijaya left review comments

@seandillon92 seandillon92 Awaiting requested review from seandillon92

+1 more reviewer

@sindharta sindharta sindharta left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@schinkowski @sindharta-tanuwijaya @sindharta