Create workflow for code testing and artifact generation #69
Conversation
unknownbrackets
left a comment
unknownbrackets
left a comment
There was a problem hiding this comment.
Thanks, I've moved away from Travis on PPSSPP too, but haven't gotten around to it here or a few other projects.
-[Unknown]
| # msbuild-architecture: x64 | ||
|
|
||
| - name: Build | ||
| run: msbuild.exe cli\\maxcso.sln -m -p:Configuration=Release -p:PlatformToolset=v141_xp -p:Platform=x64 -p:TrackFileAccess=false |
There was a problem hiding this comment.
Hm, did it fail without specifying PlatformToolset? I'm gonna try without that, because I'd prefer to be able to merge #34 without changing this file. On PPSSPP, I don't remember needing it...
-[Unknown]
There was a problem hiding this comment.
yes, it will fail, your project specs are too outdated, Travis was using msvc2017, but visual studio 2019 needs to include this flag. Or you can update your project specs by opening it in the modern visual studio. I didnt do tht cause it will raise many warning, some of them can be treated as errors, so I just provide compilable solution.
There was a problem hiding this comment.
It did build okay without it:
d30c968#diff-f9d9a4b23f1d680a037541fcd155069b6c4ca2db38a49414383ab735de964688L23
I probably will drop XP support in not that long, but there hasn't really been a reason to do it other than newer Visual Studio versions dropping support. I prefer to drop support for things in response to real limitations, not just because I think I know better than users still using XP.
-[Unknown]
| name: kelftool-macos | ||
| path: kelftool-macos.tar.gz |
There was a problem hiding this comment.
Oops, typo (or unchanged from the reference file, I'd guess.) I'll just push a fix, gonna tweak the paths-ignore as well for the conditions.
-[Unknown]
|
i also forget to bump action version. for example upload-artifact is already v3 |
|
Easy enough to update: 2a26a15. -[Unknown] |
2 participants
Just enabled here action and merge this pr