Create workflow for code testing and artifact generation #69
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| name: CI-compile | ||
|
|
||
| on: | ||
| push: | ||
| pull_request: | ||
|
|
||
| jobs: | ||
| build-windows: | ||
| name: Windows compilation | ||
| runs-on: windows-2019 | ||
|
|
||
| steps: | ||
| - name: Checkout Repository | ||
| uses: actions/checkout@v2 | ||
|
|
||
| - name: Setup msbuild | ||
| uses: microsoft/[email protected] | ||
| # with: | ||
| # vs-version: "[15.0,16.0)" | ||
| # msbuild-architecture: x64 | ||
|
|
||
| - name: Build | ||
| run: msbuild.exe cli\\maxcso.sln -m -p:Configuration=Release -p:PlatformToolset=v141_xp -p:Platform=x64 -p:TrackFileAccess=false | ||
|
|
||
| - uses: actions/upload-artifact@v2 | ||
| with: | ||
| name: maxcso-windows-${{ matrix.platform }} | ||
| path: maxcso.exe | ||
|
|
||
| build-macos: | ||
| name: MacOS compilation | ||
| runs-on: macos-latest | ||
|
|
||
| steps: | ||
| - name: Checkout Repository | ||
| uses: actions/checkout@v2 | ||
|
|
||
| - run: brew install lz4 libuv libdeflate | ||
|
|
||
| - name: Build | ||
| run: | | ||
| make | ||
| tar -zcvf kelftool-macos.tar.gz maxcso | ||
|
|
||
| - uses: actions/upload-artifact@v2 | ||
| with: | ||
| name: kelftool-macos | ||
| path: kelftool-macos.tar.gz | ||
|
Comment on lines
+47
to
+48
Owner
There was a problem hiding this comment. Oops, typo (or unchanged from the reference file, I'd guess.) I'll just push a fix, gonna tweak the paths-ignore as well for the conditions. -[Unknown] |
||
|
|
||
| build-ubuntu: | ||
| name: Ubuntu compilation | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - name: Checkout Repository | ||
| uses: actions/checkout@v2 | ||
|
|
||
| - run: sudo apt-get install libuv1-dev liblz4-dev | ||
|
|
||
| - name: Build | ||
| run: | | ||
| make | ||
| tar -zcvf maxcso-linux.tar.gz maxcso | ||
|
|
||
| - uses: actions/upload-artifact@v2 | ||
| with: | ||
| name: maxcso-linux | ||
| path: maxcso-linux.tar.gz | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, did it fail without specifying PlatformToolset? I'm gonna try without that, because I'd prefer to be able to merge #34 without changing this file. On PPSSPP, I don't remember needing it...
-[Unknown]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, it will fail, your project specs are too outdated, Travis was using msvc2017, but visual studio 2019 needs to include this flag. Or you can update your project specs by opening it in the modern visual studio. I didnt do tht cause it will raise many warning, some of them can be treated as errors, so I just provide compilable solution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It did build okay without it:
d30c968#diff-f9d9a4b23f1d680a037541fcd155069b6c4ca2db38a49414383ab735de964688L23
I probably will drop XP support in not that long, but there hasn't really been a reason to do it other than newer Visual Studio versions dropping support. I prefer to drop support for things in response to real limitations, not just because I think I know better than users still using XP.
-[Unknown]