Skip to content

Commit

Permalink
Switch workaround command to pnpm v10.3.0 strict-dep-builds setting
Browse files Browse the repository at this point in the history
  • Loading branch information
karlhorky committed Feb 11, 2025
1 parent f05f0ac commit 557ae4c
Show file tree
Hide file tree
Showing 5 changed files with 214 additions and 272 deletions.
7 changes: 1 addition & 6 deletions .github/workflows/lint-and-check-types.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,7 @@ jobs:
node-version: 'lts/*'
cache: 'pnpm'
- name: Install dependencies
# Fail on pnpm v10 ignored build scripts
#
# TODO: Switch to future `pnpm install` option to fail on pnpm v10 ignored build scripts, if accepted:
# - https://github.com/pnpm/pnpm/issues/9032#issuecomment-2647428724
# run: pnpm install --<flag here>
run: pnpm install | { has_ignored_build_scripts=false; while IFS= read -r line; do echo "$line"; [[ "$line" == *"Ignored build scripts:"* ]] && has_ignored_build_scripts=true; done; [[ "$has_ignored_build_scripts" = false ]]; }
run: pnpm install

# Fix Renovate running `pnpm install --recursive` causing `version: 'link:'` for eslint-plugin-upleveled
# https://github.com/renovatebot/renovate/discussions/22458
Expand Down
6 changes: 5 additions & 1 deletion .npmrc
Original file line number Diff line number Diff line change
@@ -1 +1,5 @@
exact=true
exact=true

# Fail on pnpm ignored build scripts
# - https://github.com/pnpm/pnpm/pull/9071
strict-dep-builds=true
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,15 +23,15 @@
"@typescript-eslint/types": "8.23.0",
"@typescript-eslint/typescript-estree": "8.23.0",
"@typescript-eslint/utils": "8.23.0",
"eslint-config-upleveled": "9.0.0",
"eslint-config-upleveled": "9.1.2",
"eslint-plugin-upleveled": "2.1.14",
"prettier": "3.4.2",
"typescript": "5.7.3"
},
"peerDependencies": {
"eslint": "^9.19.0"
},
"packageManager": "pnpm@10.2.1",
"packageManager": "pnpm@10.3.0+sha512.ee592eda8815a8a293c206bb0917c4bb0ff274c50def7cbc17be05ec641fc2d1b02490ce660061356bd0d126a4d7eb2ec8830e6959fb8a447571c631d5a2442d",
"engines": {
"node": ">=18.0.0"
},
Expand Down
Loading

0 comments on commit 557ae4c

Please sign in to comment.