Fix fontifying of variable names and overriding of keywords. #1787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* verilog-mode.el (Line#3399, verilog-declaration-varname-matcher): Fix fontifying of variable names and overriding of keywords. Signed-off-by: Gonzalo Larumbe <[email protected]>
|
Thanks for working on this! I was unable to submit a proper PR after our last discussion in that issue thread. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR partially fixes issue #1752.
The changes in the updated regexp that @kaushalmodi proposed to detect signed/unsigned declarations were included after refactoring in 72c2b1f. However after this commit there was a bug in
verilog-declaration-varname-matcherwhen trying to executeforward-sexpover a closing brace/bracket/parenthesis.The PR also avoids fontify overriding of reserved keywords on variable declarations.
It still fontifies wrongly typedef enum declarations since these need some additional debugging (possibly in future PRs).
Thanks!