Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A simpler overlay to speed up reference path queries #199

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

jeizenga
Copy link
Contributor

Includes a new overlay, ReferencePathOverlay, that has similar functionality to the PackedReferencePathOverlay except with simpler backing data structures that should be faster to access. The construction algorithm is pretty parallel, so hopefully it won't add too much to start-up time.

I've stolen the name ReferencePathOverlayHelper to refer to the ReferencePathOverlay. The older overlay helper is now named PackedReferencePathOverlayHelper.

@adamnovak This does PR does not include any updates to the Python bindings. I'm not sure if I have easy access to a computational environment where I can run the binder code. Is this mergeable without that?

@adamnovak
Copy link
Member

I'm not sure we ever bound the overlay helpers, so there probably isn't a breaking change vs. the existing generated binding code we have checked in.

@adamnovak adamnovak merged commit c8f6a12 into master Jun 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants