Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use batch path deletion interface in vg paths -d #4353

Merged
merged 3 commits into from
Jul 23, 2024
Merged

Conversation

glennhickey
Copy link
Contributor

This PR updates libdsg/libhandlegraph to the latest versions. These include mutable_path_handlegraph::destroy_paths(). This is the equivalent of calling destroy_path() on each input item, except for PackedHandleGraph which implements its own faster version (vgteam/libbdsg#201).

But there's something wrong!

paths   version   time (s)
----------------------------
1       1.58      2.8
1       this      6.7
1       hash      12.6
11      1.58      11.3
11      this      49.2 
11      hash      14
111     1.58      97.8
111     this      479
111     hash      14.2

Command lines

packed graph for 1, 11, 111 paths (switch to 2.hg) for hash graph.

time vg paths -x /private/home/hickey/dev/work/slow-vg-clip -x 2.vg -Q simHuman_999 -d
time vg paths -x /private/home/hickey/dev/work/slow-vg-clip -x 2.vg -Q simHuman_99 -d
time vg paths -x /private/home/hickey/dev/work/slow-vg-clip -x 2.vg -Q simHuman_9 -d

@glennhickey
Copy link
Contributor Author

For the record, this patch via 9429d62 seems to resolve the issue

packed graph deletion times with the patch are about 7 seconds across the board. Even doing 2500 paths (`-Q simHuman) is 40s which is in the same ballpark (30s) as hash graph. Thanks @jeizenga !

@glennhickey glennhickey changed the title [no not merge] Use batch path deletion interface in vg paths -d Use batch path deletion interface in vg paths -d Jul 22, 2024
@glennhickey glennhickey merged commit c560498 into master Jul 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants