Add BLE connection support in provisioning loop. #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t provisioning method).
maxhorowitz
changed the title
maxhorowitz
commented
Feb 3, 2025
| @@ -1,35 +1,37 @@ | |||
| module github.com/viamrobotics/agent | |||
|
|
|||
| go 1.23.1 | |||
| go 1.23.5 | |||
There was a problem hiding this comment.
Reminder to circle back and ask about dependencies here.
|
ale7714
reviewed
Feb 3, 2025
| @@ -88,6 +103,9 @@ func NewProvisioning(ctx context.Context, logger logging.Logger, updateConf *age | |||
|
|
|||
| mainLoopHealth: &health{}, | |||
| bgLoopHealth: &health{}, | |||
|
|
|||
| muProvisioningMethod: sync.Mutex{}, | |||
| provisioningMethod: provisioningMethodBLE, | |||
There was a problem hiding this comment.
FYI i'll confirm with Eliot which one should be the default. My instinct says BLE but will confirm
ale7714
reviewed
Feb 3, 2025
|
|
||
| const ( | ||
| provisioningMethodHotspot provisioningMethod = "WiFi" | ||
| provisioningMethodBLE provisioningMethod = "BLE" |
There was a problem hiding this comment.
Let's call this bluetooth. For users, setting the configuration it will be more obvious what bluetooth means.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrate BLE manager into provisioning flows (and test as the default provisioning method).