RSDK-6885 - Add fields to GetPropertiesResponse in slam.proto #458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnN193
approved these changes
Mar 11, 2024
JohnN193
approved these changes
Mar 11, 2024
This was referenced Mar 12, 2024
randhid
approved these changes
Mar 12, 2024
kkufieta
force-pushed
the
kk/rsdk-6885-change-slam-proto
branch
from
407fb63 to
871e90e
Compare
JohnN193
approved these changes
Mar 13, 2024
randhid
requested changes
Mar 13, 2024
Comment on lines
131
to
132
| string internal_state_file_type = 3; | ||
| repeated SensorInfo sensor_info = 4; |
There was a problem hiding this comment.
Double checking if these should be optional?
There was a problem hiding this comment.
We'll need sensor_info to create the replay sensors. I think we could make internal_state_file_type optional.
cc @JohnN193
kkufieta
added
bug
randhid
approved these changes
Mar 13, 2024
JohnN193
approved these changes
Mar 13, 2024
kkufieta
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://viam.atlassian.net/browse/RSDK-6885
Done:
GetPropertiesResponse:internal_state_file_typesensor_infoSDKs:
NOTE: Will not merge until SDK PRs are ready.