RSDK-12146 Add AudioIn Component #5369
Open
+813
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
oliviamiller
commented
Oct 13, 2025
go.mod
Outdated
| golang.org/x/exp v0.0.0-20241009180824-f66d83c29e7c | ||
| ) | ||
|
|
||
| replace go.viam.com/api => ../api |
There was a problem hiding this comment.
Will change this once viamrobotics/api#761 is merged
There was a problem hiding this comment.
Now that this was already merged viamrobotics/api#761, can this like be updated?
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
seanavery
reviewed
Oct 14, 2025
|
@oliviamiller Would you mind adding link to POC implementation in the desc? |
hexbabe
reviewed
Oct 14, 2025
hexbabe
requested changes
Oct 14, 2025
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
oliviamiller
commented
Oct 17, 2025
| done | ||
| if $is_cgo_path; then | ||
| if grep -Fq "$expectedImport" register_apis/* 2>/dev/null; then | ||
| echo "Detected restricted cgo import '$expectedImport' in 'rdk/$p/register_apis'" |
There was a problem hiding this comment.
Had to edit this lint script bc it was just matching substring so thought audioin was a cgo package
viambot
added
safe to test
viambot
added
safe to test
oliviamiller
commented
Oct 17, 2025
| return nil, err | ||
| } | ||
|
|
||
| // receive one chunk outside of the goroutine to catch any errors |
There was a problem hiding this comment.
Realized I had a bug with client error handling so this is different than first review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add AudioIn component to RDK.
Tested using the audio module POC, confirmed that the stream shuts down correctly when closing from both client and server side.