Making chopper available via command line#886
Merged
marcoeilers merged 5 commits intomasterfrom Sep 23, 2025
Merged
Conversation
…on, removing old --methods option
Contributor
|
While I originally went with this design, I decided against this option, as it introduces a change of the API that is, in my view, unnecessary. Instead, I extended the trait with a new algorithm to compute the edges in the |
Contributor
Author
|
Ah right, I forgot about that. |
Co-authored-by: João Pereira <joaopereira.19@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Chopper is great but currently not available via the command line. This PR changes that.
It adds a new option
--select=name1,name2,name3that allows users to select some subset of the members of the selected program to be verified, and then uses the Chopper to generate a Viper program containing only these methods and their necessary dependencies.It also removes the older command line option
--methods=namethat tried to do something similar but only filtered methods and did not take into account dependencies (and that I've never seen anyone actually use).This change requires making the Chopper aware of termination plugin dependencies; the code for doing this is taken from @jcp19's PR https://github.com/viperproject/silver/pull/832/files.