Skip to content

Conversation

@wonjerry
Copy link
Contributor

PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS (AT THE BOTTOM) HAVE BEEN CONSIDERED.

Purpose

Improve documentation for output modality control in online serving.

The current documentation only shows Python client script usage (--modalities flag) but lacks API-level usage examples. This PR adds:

  • curl examples showing how to use modalities parameter in API requests
  • OpenAI Python SDK examples
  • Clear documentation of supported modality values and their behavior

Related to PR #298 which implemented the modality control feature.

Test Plan

Documentation changes only. Verified markdown syntax is correct.

Test Result

N/A (documentation only)


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft.

BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)

- Add curl example for modalities parameter
- Add OpenAI Python SDK example
- Document supported modality values (text, audio)
- Clarify that audio output includes text (audio generation requires text)

Signed-off-by: wonjae.lee0 <[email protected]>
@wonjerry wonjerry force-pushed the docs/add-modality-control-api-usage branch from 9806470 to 38378ad Compare December 23, 2025 00:30
@wonjerry
Copy link
Contributor Author

@hsliuustc0106 PTAL thx

@wonjerry wonjerry force-pushed the docs/add-modality-control-api-usage branch from 0c46be1 to e26bdfa Compare December 24, 2025 01:50
- Add Text + Audio examples for curl and OpenAI Python SDK
- Update modalities table with all supported options
- Clarify that default (not specified) returns Text + Audio
- Remove max_tokens parameter (not working)

Signed-off-by: wonjae.lee0 <[email protected]>
@wonjerry wonjerry force-pushed the docs/add-modality-control-api-usage branch from e26bdfa to bc06960 Compare December 24, 2025 01:50
@hsliuustc0106 hsliuustc0106 added the ready label to trigger buildkite CI label Dec 24, 2025
@hsliuustc0106 hsliuustc0106 enabled auto-merge (squash) December 24, 2025 07:19
Copy link
Collaborator

@hsliuustc0106 hsliuustc0106 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hsliuustc0106 hsliuustc0106 merged commit cbaf508 into vllm-project:main Dec 24, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready label to trigger buildkite CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants