Skip to content

Conversation

@lucasmenendez
Copy link
Contributor

@lucasmenendez lucasmenendez commented Dec 17, 2025

  • Tests split in different files
    • Offchain static merkle tree census test
    • Offchain dynamic merkle tree census test
    • CSP census test
    • Max voters test
    • Overwrite votes test
  • Helpers refactored and moved to a single package

@lucasmenendez lucasmenendez self-assigned this Dec 17, 2025
@lucasmenendez lucasmenendez added the enhancement New feature or request label Dec 17, 2025
@lucasmenendez lucasmenendez force-pushed the f/better_integration_tests branch from 8e80637 to 935e52a Compare December 17, 2025 13:19
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the integration test suite by splitting tests into separate files and consolidating helper functions into a dedicated helpers package. The changes improve test organization and maintainability.

Key Changes:

  • Test cases separated into specific test files (vote overwriting, census types, max voters, error handling)
  • Helper functions moved from helpers_test.go to a new tests/helpers package with better organization
  • Main test setup moved from deleted helper file to main_test.go

Reviewed changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
tests/overwrites_votes_test.go New test file for vote overwriting scenarios
tests/offchain_merkletree_static_census_test.go New test for static merkle tree census
tests/offchain_merkletree_dynamic_census_test.go New test for dynamic census updates
tests/max_voters_test.go New test for maximum voters limit handling
tests/main_test.go Consolidated test setup with helpers package integration
tests/integration_test.go Refactored to use helpers package with t.Skip() added
tests/helpers_test.go Removed (moved to helpers package)
tests/helpers/vote.go Vote creation and validation helpers
tests/helpers/results.go Results retrieval helper
tests/helpers/process.go Process management helpers
tests/helpers/org.go Organization creation helper
tests/helpers/constants.go Test constants and configuration
tests/helpers/common.go Common utility functions
tests/helpers/census.go Census creation and proof helpers
tests/errors_test.go New test file for error scenarios
tests/docker/deploy.sh Gas price configuration for deployment
tests/csp_census_test.go New test for CSP census functionality

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@lucasmenendez lucasmenendez force-pushed the f/better_integration_tests branch 2 times, most recently from 7ca5242 to ec2b8e0 Compare December 17, 2025 13:33
@lucasmenendez lucasmenendez marked this pull request as ready for review December 17, 2025 14:12
@vocdoni vocdoni deleted a comment from chatgpt-codex-connector bot Dec 17, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated 8 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@altergui altergui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i can address these changes myself when i finish reviewing

@altergui altergui force-pushed the f/better_integration_tests branch from dafbe2f to 30fb067 Compare December 29, 2025 09:42
@altergui
Copy link
Contributor

altergui commented Jan 5, 2026

(reviewed until the end)

@p4u
Copy link
Member

p4u commented Jan 6, 2026

@lucasmenendez rebase, re-review yourself, and fix all comments please, before it diverges more from main.

@lucasmenendez lucasmenendez force-pushed the f/better_integration_tests branch from 30fb067 to 8b47b47 Compare January 14, 2026 09:05
@lucasmenendez lucasmenendez force-pushed the f/better_integration_tests branch from 8b47b47 to 19bf7c1 Compare January 14, 2026 09:09
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 22 out of 22 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants