-
Notifications
You must be signed in to change notification settings - Fork 2
feature: better integration tests #281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
8e80637 to
935e52a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR refactors the integration test suite by splitting tests into separate files and consolidating helper functions into a dedicated helpers package. The changes improve test organization and maintainability.
Key Changes:
- Test cases separated into specific test files (vote overwriting, census types, max voters, error handling)
- Helper functions moved from
helpers_test.goto a newtests/helperspackage with better organization - Main test setup moved from deleted helper file to
main_test.go
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/overwrites_votes_test.go | New test file for vote overwriting scenarios |
| tests/offchain_merkletree_static_census_test.go | New test for static merkle tree census |
| tests/offchain_merkletree_dynamic_census_test.go | New test for dynamic census updates |
| tests/max_voters_test.go | New test for maximum voters limit handling |
| tests/main_test.go | Consolidated test setup with helpers package integration |
| tests/integration_test.go | Refactored to use helpers package with t.Skip() added |
| tests/helpers_test.go | Removed (moved to helpers package) |
| tests/helpers/vote.go | Vote creation and validation helpers |
| tests/helpers/results.go | Results retrieval helper |
| tests/helpers/process.go | Process management helpers |
| tests/helpers/org.go | Organization creation helper |
| tests/helpers/constants.go | Test constants and configuration |
| tests/helpers/common.go | Common utility functions |
| tests/helpers/census.go | Census creation and proof helpers |
| tests/errors_test.go | New test file for error scenarios |
| tests/docker/deploy.sh | Gas price configuration for deployment |
| tests/csp_census_test.go | New test for CSP census functionality |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
7ca5242 to
ec2b8e0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 19 out of 19 changed files in this pull request and generated 8 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
altergui
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i can address these changes myself when i finish reviewing
dafbe2f to
30fb067
Compare
|
(reviewed until the end) |
|
@lucasmenendez rebase, re-review yourself, and fix all comments please, before it diverges more from main. |
30fb067 to
8b47b47
Compare
8b47b47 to
19bf7c1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 22 out of 22 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Uh oh!
There was an error while loading. Please reload this page.