feature: better integration tests

api/types.go

@@ -16,7 +16,7 @@ type CensusParticipant struct {
 // Vote is the struct to represent a vote in the system. It will be provided by
 // the user to cast a vote in a process.
 type Vote struct {
-	ProcessID        *types.ProcessID         `json:"processId"`
+	ProcessID        types.ProcessID          `json:"processId"`
 	CensusProof      types.CensusProof        `json:"censusProof"`
 	Ballot           *elgamal.Ballot          `json:"ballot"`
 	BallotProof      *circomgnark.CircomProof `json:"ballotProof"`

api/vote.go

@@ -117,7 +117,7 @@ func (a *API) newVote(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 	// get the process from the storage
-	process, err := a.storage.Process(*vote.ProcessID)
+	process, err := a.storage.Process(vote.ProcessID)
 	if err != nil {
 		ErrResourceNotFound.Withf("could not get process: %v", err).Write(w)
 		return
@@ -139,7 +139,7 @@ func (a *API) newVote(w http.ResponseWriter, r *http.Request) {
 	// the vote will be accepted, but it is a precondition to accept the vote,
 	// for example, if the process is not in this sequencer, the vote will be
 	// rejected
-	if ok, err := a.storage.ProcessIsAcceptingVotes(*vote.ProcessID); !ok {
+	if ok, err := a.storage.ProcessIsAcceptingVotes(vote.ProcessID); !ok {
 		if err != nil {
 			ErrProcessNotAcceptingVotes.WithErr(err).Write(w)
 			return
@@ -156,7 +156,7 @@ func (a *API) newVote(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 	if !isOverwrite {
-		if maxVotersReached, err := a.storage.ProcessMaxVotersReached(*vote.ProcessID); err != nil {
+		if maxVotersReached, err := a.storage.ProcessMaxVotersReached(vote.ProcessID); err != nil {
 			ErrGenericInternalServerError.Withf("could not check max voters: %v", err).Write(w)
 			return
 		} else if maxVotersReached {
@@ -195,7 +195,7 @@ func (a *API) newVote(w http.ResponseWriter, r *http.Request) {
 	}
 	// calculate the ballot inputs hash
 	ballotInputsHash, err := ballotproof.BallotInputsHash(
-		*vote.ProcessID,
+		vote.ProcessID,
 		process.BallotMode,
 		new(bjj.BJJ).SetPoint(process.EncryptionKey.X.MathBigInt(), process.EncryptionKey.Y.MathBigInt()),
 		vote.Address,
@@ -240,7 +240,7 @@ func (a *API) newVote(w http.ResponseWriter, r *http.Request) {
 	}
 	// Create the ballot object
 	ballot := &storage.Ballot{
-		ProcessID:   *vote.ProcessID,
+		ProcessID:   vote.ProcessID,
 		VoterWeight: voterWeight.MathBigInt(),
 		// convert the ballot from TE (circom) to RTE (gnark)
 		EncryptedBallot:  vote.Ballot.FromTEtoRTE(),

cmd/e2e-test/main.go

@@ -627,7 +627,7 @@ func createVote(
 
 	// Return the vote ready to be sent to the sequencer
 	return api.Vote{
-		ProcessID:        &wasmResult.ProcessID,
+		ProcessID:        wasmResult.ProcessID,
 		Address:          wasmInputs.Address,
 		Ballot:           wasmResult.Ballot,
 		BallotProof:      circomProof,