refactor: unify pre-commit configs and update CI workflow #15
Conversation
kluge7
changed the title
…yaml and update CI workflow to use that new file, also removed pre-commit.ci badge from README
kluge7
force-pushed
the
ci/refactor-pre-commit
branch
from
4b13e70 to
9daf0cf
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR consolidates pre-commit configuration by merging .pre-commit-config-local.yaml into .pre-commit-config.yaml, updates the CI workflow to use the unified configuration file, and removes the pre-commit.ci badge from the README.
- Merged local ROS2 ament linter hooks (ament_cppcheck, ament_cpplint, ament_lint_cmake) into the main pre-commit config
- Updated GitHub workflow to reference
.pre-commit-config.yamlinstead of.pre-commit-config-local.yaml - Removed pre-commit.ci badge from README and added
.vscode/andlog/to .gitignore
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Removed pre-commit.ci badge, consistent with moving away from the pre-commit.ci service |
| .pre-commit-config.yaml | Added three local ROS2 ament linter hooks from the local config file |
| .pre-commit-config-local.yaml | Contains a stray "r" character that should be removed |
| .gitignore | Added .vscode/ and log/ directory ignores |
| .github/workflows/pre-commit.yml | Updated to use .pre-commit-config.yaml instead of .pre-commit-config-local.yaml |
Comments suppressed due to low confidence (1)
.pre-commit-config-local.yaml:21
- The file should be completely empty or deleted after merging its content into
.pre-commit-config.yaml. The stray character "r" on line 21 appears to be a typo and will cause YAML parsing errors if this file is accidentally used.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #15 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 3 3
Lines 234 234
Branches 18 18
=====================================
Misses 234 234
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -1,11 +1,14 @@ | |||
| name: pre-commit | |||
There was a problem hiding this comment.
[nitpick] Inconsistent formatting: This workflow file is missing a blank line after the name: declaration, while other workflow files in this PR (industrial-ci.yml, code-coverage.yml, semantic-release.yml) maintain a blank line between name: and on:. Consider adding a blank line after line 1 for consistency.
| name: pre-commit | |
| name: pre-commit |
No description provided.