Skip to content

refactor: unify pre-commit configs and update CI workflow #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kluge7 merged 3 commits into from
Nov 16, 2025
Merged

refactor: unify pre-commit configs and update CI workflow #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
728f39e
chore: update .gitignore to exclude .vscode/ and log/
kluge7 Nov 16, 2025
9daf0cf
refactor: merge .pre-commit-config-local.yaml and .pre-commit-config.…
kluge7 Nov 16, 2025
81b3b31
refactor(workflows): update job names and when different workflows run
kluge7 Nov 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .github/workflows/code-coverage.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,9 @@ on:
branches:
- main
pull_request:
branches:
- main
types: [ opened, synchronize, reopened, ready_for_review ]
jobs:
call_reusable_workflow:
code-coverage:
uses: vortexntnu/vortex-ci/.github/workflows/reusable-code-coverage.yml@main
secrets:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}
6 changes: 5 additions & 1 deletion .github/workflows/industrial-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,15 @@ name: Industrial CI

on:
push:
branches:
- main
pull_request:
types: [ opened, synchronize, reopened, ready_for_review ]
workflow_dispatch:
schedule:
- cron: '0 1 * * *' # Runs daily to check for dependency issues or flaking tests
jobs:
call_reusable_workflow:
industrial-ci:
uses: vortexntnu/vortex-ci/.github/workflows/reusable-industrial-ci.yml@main
with:
ros_repo: '["testing", "main"]'
9 changes: 6 additions & 3 deletions .github/workflows/pre-commit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,14 @@
name: pre-commit
Copy link

Copilot AI Nov 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Inconsistent formatting: This workflow file is missing a blank line after the name: declaration, while other workflow files in this PR (industrial-ci.yml, code-coverage.yml, semantic-release.yml) maintain a blank line between name: and on:. Consider adding a blank line after line 1 for consistency.

Suggested change
name: pre-commit
name: pre-commit

Copilot uses AI. Check for mistakes.

on:
push:
branches:
- main
pull_request:
types: [ opened, synchronize, reopened, ready_for_review ]
workflow_dispatch:
jobs:
call_reusable_workflow:
pre-commit:
uses: vortexntnu/vortex-ci/.github/workflows/reusable-pre-commit.yml@main
with:
ros_distro: 'humble'
config_path: '.pre-commit-config-local.yaml'
config_path: '.pre-commit-config.yaml'
2 changes: 1 addition & 1 deletion .github/workflows/semantic-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,5 @@ on:
branches:
- main
jobs:
call_reusable_workflow:
semantic-release:
uses: vortexntnu/vortex-ci/.github/workflows/reusable-semantic-release.yml@main
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,3 +50,6 @@ qtcreator-*

# Catkin custom files
CATKIN_IGNORE

.vscode/
log/
51 changes: 0 additions & 51 deletions .pre-commit-config-local.yaml
View file
Open in desktop

This file was deleted.

29 changes: 29 additions & 0 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,35 @@ repos:
hooks:
- id: clang-format
args: [--style=file]
- repo: local
hooks:
- id: ament_cppcheck
name: ament_cppcheck
description: Static code analysis of C/C++ files.
entry: env AMENT_CPPCHECK_ALLOW_SLOW_VERSIONS=1 ament_cppcheck
language: system
files: \.(h\+\+|h|hh|hxx|hpp|cuh|c|cc|cpp|cu|c\+\+|cxx|tpp|txx)$
- repo: local
hooks:
- id: ament_cpplint
name: ament_cpplint
description: Static code analysis of C/C++ files.
entry: ament_cpplint
language: system
files: \.(h\+\+|h|hh|hxx|hpp|cuh|c|cc|cpp|cu|c\+\+|cxx|tpp|txx)$
args: [
"--linelength=100",
"--filter=-whitespace/newline,-legal/copyright,-build/include_order"
]
# CMake hooks
- repo: local
hooks:
- id: ament_lint_cmake
name: ament_lint_cmake
description: Check format of CMakeLists.txt files.
entry: ament_lint_cmake
language: system
files: CMakeLists\.txt$
# Spellcheck in comments and docs
- repo: https://github.com/codespell-project/codespell
rev: v2.4.1
Expand Down
1 change: 0 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
# Image Filtering Node
[![Industrial CI](https://github.com/vortexntnu/vortex-image-filtering/actions/workflows/industrial-ci.yml/badge.svg)](https://github.com/vortexntnu/vortex-image-filtering/actions/workflows/industrial-ci.yml)
[![pre-commit.ci status](https://results.pre-commit.ci/badge/github/vortexntnu/vortex-image-filtering/main.svg)](https://results.pre-commit.ci/latest/github/vortexntnu/vortex-image-filtering/main)
[![codecov](https://codecov.io/github/vortexntnu/vortex-image-filtering/graph/badge.svg?token=6XHprkpUsR)](https://codecov.io/github/vortexntnu/vortex-image-filtering)

The `image_filtering_node` is a ROS 2 node developed in the `vortex::image_filters` namespace. It is designed to subscribe to image topics, apply various image filters using OpenCV, and publish the filtered images back to ROS.
Expand Down