modulesync 10.4.0 #431
Merged
modulesync 10.4.0 #431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheMeier
added
backwards-incompatible
TheMeier
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
bastelfreak
force-pushed
the
modulesync
branch
2 times, most recently
from
3e7c5e6 to
b5540a2
Compare
bastelfreak
added
modulesync
bastelfreak
changed the title
bastelfreak
force-pushed
the
modulesync
branch
from
b5540a2 to
ecce15d
Compare
bastelfreak
pushed a commit
to bastelfreak/puppet-puppetboard
that referenced
this pull request
Dec 5, 2025
the original modulesync PR is failing, so we are trying to apply just some parts to figure out the broken pieces. see voxpupuli#431
This comment was marked as outdated.
This comment was marked as outdated.
Member
|
Looks like #437 was never tested and does not pass per: Reverting this commit allow the unit tests to pass. #437 has not been released yet, my suggestion is to remove it for now and move on with this module. @bwitt does this look reasonable to you? |
smortex
force-pushed
the
modulesync
branch
2 times, most recently
from
525e73d to
3656b95
Compare
This was referenced Dec 26, 2025
Contributor
|
@smortex sounds good thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modulesync 10.0.0-19-g1adc8e0